Feat: use framework info

[erezrokah]

Summary

Fixes #1495
Fixes #1252

• Verify this works with fix(command-dev): detect other Jekyll config file names #2312

Related to #843

Changes in behavior

Changes from #843

• framework = "#custom".
  • Current behavior - an error is shown if command and targetPort are not configured.
  • New behavior - same as current.
• framework is not #custom and user has specified command and targetPort.
  • Current behavior - an error is shown to set framework = "#custom".
  • New behavior - everything works as the CLI has all the information it needs to run. This allows running ntl dev --command "echo hello" --targetPort 8000 which was not supported before (adding --framework "#custom" didn't work as well).
• dir flag is specified.
  • Current behavior - we don't run framework detection, use a static server and show an error if targetPort or command are specified.
  • New behavior - we don't run framework detection and use a static server.
    • If command is configured we print a warning and suggest to use targetPort for a custom setup.
    • If targetPort is configured we print a warning and suggest to use staticServerPort to configure the static server port.

Other changes

• framework = "create-react-app" (or any other specific framework)

  • Current behavior - run the create-react-app detector, if it fails report an error, otherwise use it
  • New behavior - always use the specific framework settings

• Added a new --framework flag. You can only configure framework using the dev block at the moment. That doesn't make sense since we already have command and targetPort flags. Done in feat(command-dev): add framework flag #2818

Test plan

Testing this manually at the moment.
Will think of a good way to test the integration without having a performance hit.

Tested only the happy path, so others are probably broken.

Replaced the unit tests with integration tests

Tests were added in #2821, I've updated them to reflect the new behavior

- A picture of a cute animal (not mandatory but encouraged)

[github-actions]

📊 Benchmark results

Comparing with 0b5c891

• Package size: 389 MB (no change)

[github-actions]

📊 Benchmark results

Comparing with 728826e

Package size: 330 MB

(no change)

^  330 MB  330 MB  330 MB  330 MB  330 MB  330 MB  330 MB  330 MB  330 MB  330 MB  330 MB  330 MB  330 MB 
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    

Legend

• T-30 (728826e): 330 MB
• T-29 (321e2b2): 330 MB
• T-28 (e459351): 330 MB
• T-27 (320d42f): 330 MB
• T-26 (b7f84e4): 330 MB
• T-25 (20a9de9): 330 MB
• T-24 (315d616): 330 MB
• T-23 (aa6c8fb): 330 MB
• T-22 (9ef19aa): 330 MB
• T-21 (75299ba): 330 MB
• T-20 (32c6086): 330 MB
• T-19 (ced0c93): 330 MB
• T-18 (7ccf859): 330 MB
• T-17 (278557a): 330 MB
• T-16 (db8c431): 330 MB
• T-15 (a53b36f): 330 MB
• T-14 (08d87ff): 329 MB
• T-13 (0767251): 329 MB
• T-12 (307e128): 330 MB
• T-11 (c68efb2): 330 MB
• T-10 (bbb78bd): 330 MB
• T-9 (2c6a57a): 330 MB
• T-8 (8bfdb2f): 330 MB
• T-7 (2e18003): 330 MB
• T-6 (fd3d2f7): 330 MB
• T-5 (d451cb3): 330 MB
• T-4 (c381072): 330 MB
• T-3 (537b760): 330 MB
• T-2 (172c955): 330 MB
• T-1 (259dd5f): 330 MB
• T (current commit): 330 MB