fix(command-dev): use waitPort built-in http request support #2842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 94f64a4 Package size: 331 MB(no change) Legend
|
erezrokah
commented
Jul 5, 2021
| @@ -93,35 +86,12 @@ const startFrameworkServer = async function ({ settings, log, exit }) { | |||
| port: settings.frameworkPort, | |||
| output: 'silent', | |||
| timeout: FRAMEWORK_PORT_TIMEOUT, | |||
| ...(settings.disableLocalServerPolling ? {} : { protocol: 'http' }), | |||
There was a problem hiding this comment.
This option is documented via the library types and somehow here too.
There was a problem hiding this comment.
@eduardoboucas can you verify this doesn't break the original fix (I remember you had issues with this when running create-react-app).
There was a problem hiding this comment.
@eduardoboucas can you verify this doesn't break the original fix (I remember you had issues with this when running
create-react-app).
It seems to work fine! I remember the issue was with a Gatsby site and I'm not able to replicate it using this branch.
erezrokah
requested review from
eduardoboucas
and removed request for
eduardoboucas
eduardoboucas
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Related to #1704
Uses
waitPortbuilt in support for testingHTTPrequests instead of polling ourselves.- Test plan
Existing tests, I'll verify with various frameworks manually too.
- A picture of a cute animal (not mandatory but encouraged)
😼