-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netlify Dev: Add framework = "#custom" option #843
Conversation
It sounds like our heuristics are getting thrown off. Do we know specific reasons why inferred build command and port didn’t work for the linked issues? It seems ideal to address this by being very clear about what configuration has been inferred. If we do go the disabling route, consider adding an option for disabling heuristics (would need a sensible name not involving the word “heuristics”) rather than accepting a special framework name. |
Highlights
|
- Summary
This is to clear confusion around usage.
If
framework = "#custom"
innetlify.toml
dev
section, the user must specifycommand
andtargetPort
options as well and we'll throw an error if they're missing any of these.If
framework
is not#custom
and user has specifiedcommand
andtargetPort
options, we'll throw an error and ask them setframework
to#custom
.If
dir
flag is specified, we'll ignore all detectors and throw an error iftargetPort
orcommand
is specified.Fixes: #827
Fixes: #441
Fixes: #851
Fixes: #862
Fixes: #850
Fixes: #847
- Test plan
netlify dev
in your project- Description for the changelog
framework = "#custom"
option fornetlify.toml
'sdev
section--dir
flag withcommand
ortargetPort
config options- A picture of a cute animal (not mandatory but encouraged)
👻