Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications api #847
Notifications api #847
Changes from 2 commits
f090cec
e6a5985
b244dea
c70829d
e1c2a0a
9e3af47
ef6f007
ea726bc
21a7478
8e45946
8aea425
b46df80
d10c453
3b358ec
af75c78
79449d0
05f2427
fada6ed
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did MagicMock come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the mocking library has
Mock
andMagicMock
which behave the same except that the latter also mock magic methods (__xyz__
shaped methods).AsyncMock
does always mock magic methods as well (I suppose it has to, to be able to intercept calls to__await__
, but that is speculation). Either way, by default the unasync script would turnAsyncMock
intoMock
which brakes tests that rely on magic methods being mocked.