Notifications api #847
Merged
Notifications api #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsdedude
commented
Oct 28, 2022
robsdedude
commented
Oct 28, 2022
* ADR update neo-technology/drivers-adr#56 * Split filtering into two config options * Simplified driver by removing requirement for protocol optimizations * Slightly adjusted protocol specs * Finalized documentation
Methods forwarded to the wrapped socket need to live on the wrapper object, not the class.
Methods forwarded to the wrapped socket need to altered on the wrapper object, not the class.
bigmontz
requested changes
Mar 20, 2023
| @@ -223,6 +223,7 @@ def apply_unasync(files): | |||
| "assert_awaited_once": "assert_called_once", | |||
| "assert_awaited_once_with": "assert_called_once_with", | |||
| "await_count": "call_count", | |||
| "AsyncMock": "MagicMock", | |||
There was a problem hiding this comment.
Where did MagicMock come from?
There was a problem hiding this comment.
the mocking library has Mock and MagicMock which behave the same except that the latter also mock magic methods (__xyz__ shaped methods). AsyncMock does always mock magic methods as well (I suppose it has to, to be able to intercept calls to __await__, but that is speculation). Either way, by default the unasync script would turn AsyncMock into Mock which brakes tests that rely on magic methods being mocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on