-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications api #847
Merged
Merged
Notifications api #847
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
f090cec
Make neo4j.work internal
robsdedude e6a5985
Implement notification filters (Bolt 5.2)
robsdedude b244dea
formatting
robsdedude c70829d
Add tests to make sure credentials aren't logged
robsdedude e1c2a0a
Adjust notifications default values and combinations
robsdedude 9e3af47
Add notification position and improve docs
robsdedude ef6f007
Merge branch '5.0' into notifications-api
robsdedude ea726bc
Merge branch '5.0' into notifications-api
robsdedude 21a7478
Add basic Bolt 5.1 support
robsdedude 8e45946
WIP
robsdedude 8aea425
Update notifications API
robsdedude b46df80
Fix sync socket wrapper
robsdedude d10c453
Merge branch '5.0' into notifications-api
robsdedude 3b358ec
Add LOGON pipelining optimization to TestKit feature flags
robsdedude af75c78
Fix sync socket wrapper
robsdedude 79449d0
Polish
robsdedude 05f2427
TestKit backend: fix notification serialization
robsdedude fada6ed
Fix doc tests
robsdedude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did MagicMock come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the mocking library has
Mock
andMagicMock
which behave the same except that the latter also mock magic methods (__xyz__
shaped methods).AsyncMock
does always mock magic methods as well (I suppose it has to, to be able to intercept calls to__await__
, but that is speculation). Either way, by default the unasync script would turnAsyncMock
intoMock
which brakes tests that rely on magic methods being mocked.