Reconciled lerna package split #444
Conversation
…na-ize Conflicts: docs/swagger/swagger-json.js package-lock.json package.json packages/udaru-hapi-plugin/index.js
|
LGTM :) |
WIP - Get user teams
chore: release 3.1.0 preps
…lumeRunner starting server
fix: allow empty results when the user is in no teams
volume data insertion and autocannon bench tests
…tant and needed to be reversed
Search teams, @jimmymintzer can you rebase the nested teams against this merge and check the response model as I think it might break
* add nested teams to udaru core * add nested endpoint * add e2e test for nested team limit * updating version and changes.md, updated pbac to 0.3.0 * use the buildParams directly to create base resource for user requests * return 404 if nested team is not found
* Support in udaru core for searching users * Linting fix * Added some sanity check sql injection tests * Linting fix (again) * Linting fix (again again) * expose public user search route * add search users in a team * Updated end to end testing for teams search and team users search * updated version and changes * updated changes.md 4.1.0 date
|
Hi Guys, I merged everything and tests are passing, that's no guarantee that everything is perfect at this point but please do pull it down, lerna clean and lerna bootstrap (npm i works from root) and build and try out stuff... for some reason some files like swagger.js ended up being a very old version when i rebased so I overwrote that file, same with server.js under udaru-server... it was missing forked child stuff (not sure why it didn't merge, maybe a disconnect when moving to server folder e.g. delete commit and re-add?)... I'm hoping there's not other places like that but it seems as most recent search code is in place in the core and server and tests are in place... I tried a good few commands out and regenerated the swagger docs, seems OK and re-committed those Let me know if you find any issues, it needs a review now... the commit history above is all over the place now because of rebase with master... Merging can be performed automatically but would like someone to review and make sure ok Coverage has dropped on udaru-core as udaru-server was providing some coverage for this. Need a release plan strategy next as there are now 4 packages to release need air... |
|
Great job @cianfoley-nearform! I did some sanity checks locally and it all looks good to me. I'm tempted to hit the One odd thing though, I ran |
|
@dberesford it might be because the test db is initialised in the root package, we might need to set up the test fixture npm command in each sub project |
|
Also, I wonder should I compare each file with master individually (especially in udaru core) to see if anything has gone awry? |
|
@dberesford @mihaidma @IvanJov @jimmymintzer Please review:
Some concerns: @mihaidma the docker file you created in root was also deleted in a previous commit that took effect on merge (maybe it's covered off in compose now) All tests pass in any case (memory leak issue solved), I had to change test on policy conflict and the message coming up from udaru because the err object had no err.detail, this is a concern too (you'll see in commit 4e58015). Final issues, which can probably be addressed later based on prioritisation of tasks, is that we probably need to move anything related to test into test package e.g. loadFixtures, loadVolumeDb etc. so that all sub projects can init db before they run their independent tests. Also each project may require it's own documentation potentially but as they're part of single git hub project may not be 100% necessary once we document them individually correctly and maybe link out to individual sections from within each projects own readmes etc |
Merge out from master to @wprl's lerna fork https://github.com/wprl/udaru/tree/lerna-ize -
this supersedes #439.