This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
fix: allow empty results when the user is in no teams #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
floridemai
approved these changes
Feb 13, 2018
| @@ -312,10 +312,11 @@ exports.register = function (server, options, next) { | |||
| handler: function (request, reply) { | |||
| const { id } = request.params | |||
| const { organizationId } = request.udaru | |||
| const { limit, page } = request.query | |||
| const limit = request.query.limit || server.udaruConfig.get('authorization.defaultPageSize') | |||
There was a problem hiding this comment.
Can this be done with Joi.default()? => reusable validation and no extra code needed in the handler 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #453
This unifies the implementation with the ones made at similar endpoints, like get users:
There seems to be some implementation on
Get team usersthat is not consistent with the other endpoints, will open an issue to investigate it.