Skip to content
This repository was archived by the owner on Aug 19, 2022. It is now read-only.

Split code into 4 packages using lerna. #439

Closed
wants to merge 1 commit into from
Closed

Split code into 4 packages using lerna. #439

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 16, 2017

Splits udaru into 4 packages: udaru (core), udaru-hapi-plugin, udaru-server, udaru-test managed by lerna.

A few tasks left to fully complete #436:

  • Fix merge conflicts
  • Coverage/badges for udaru-hapi-plugin
  • Set up coveralls for each package
  • README polish?
  • Release instructions (docs/contributing.md)
  • Update website?
  • Publish packages to npm with lerna publish

What did I miss?

@mihaidma
Copy link
Contributor

@dberesford should we publish Udaru 3.0 before splitting? After the split i suppose packages will have separate versioning.

@coveralls
Copy link

coveralls commented Nov 16, 2017

Coverage Status

Coverage increased (+0.9%) to 97.115% when pulling e15b154 on wprl:lerna-ize into a7758fa on nearform:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 94.041% when pulling 0ff3258 on wprl:lerna-ize into a7758fa on nearform:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 94.041% when pulling 0ff3258 on wprl:lerna-ize into a7758fa on nearform:master.

@coveralls
Copy link

coveralls commented Nov 16, 2017

Coverage Status

Coverage decreased (-2.2%) to 94.041% when pulling 1489b34 on wprl:lerna-ize into a7758fa on nearform:master.

@coveralls
Copy link

coveralls commented Nov 16, 2017

Coverage Status

Coverage decreased (-2.2%) to 94.041% when pulling 7bf0d60 on wprl:lerna-ize into a7758fa on nearform:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 94.041% when pulling 12c657f on wprl:lerna-ize into a7758fa on nearform:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 94.041% when pulling 12c657f on wprl:lerna-ize into a7758fa on nearform:master.

@dberesford
Copy link
Contributor

@mihaidma yes we should before this lands. Are you happy to publish?

@dberesford
Copy link
Contributor

Really great work @wprl!
It all looks very good to me. One extra thing to consider are the release instructions in docs/contributing.md, they will probably need updating. Also the udaru website (nearform.github.io/udaru) is generated from this repo, it may need updating also.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 94.041% when pulling 961a429 on wprl:lerna-ize into a7758fa on nearform:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 94.041% when pulling 961a429 on wprl:lerna-ize into a7758fa on nearform:master.

@coveralls
Copy link

coveralls commented Nov 17, 2017

Coverage Status

Coverage decreased (-2.2%) to 94.041% when pulling 961a429 on wprl:lerna-ize into a7758fa on nearform:master.

@dberesford
Copy link
Contributor

dberesford commented Jan 26, 2018

Conflicts removed on https://github.com/nearform/udaru/tree/wprl-lerna-ize, this PR is superseded by #444

@dberesford dberesford closed this Jan 26, 2018
dberesford added a commit that referenced this pull request Mar 16, 2018
* Split code into 4 packages using lerna.

* Reconsiled master merge out to wprl:lerna-ize (#439)

* feat: get user teams, no inheritance

* fix: get user teams functionality, tests

* chore: changes feedback review

* chore: release 3.1.0 preps

* fix: allow empty results when the user is in no teams

* volume data insertion and autocannon bench tests

* database migration to 6, added index to team_members, fixed bug in volumeRunner starting server

* updated NUM_TEAMs in config to 500

* Forking child process for UDARU server in volumeRunner

* tidy ups and upgraded lodash to 4.17.5

* added chalk to volume load/test, using IPC when forking server, updated changes.md

* updated intermittently failing user policies test cases

* updated pbac version, iam.js also changed as the param order is important and needed to be reversed

* support for optional metadata field, team, user, org read only

* get, post and put updated for optional metadata field

* test cases on core added for create, update, read

* #450 solved: authorization pre-check required on teams payload object

* version 3.2.0 not 3.2.1

* updates to validatation models for better swagger definitions, enforcement of allow/deny on policies

* added test for issue #475 (invalid effect data)

* added a note to pagedteamslist to state policies and users not populated

* updates to all entities to throw 409 conflict instead of 400 for db insert/update conflict constraints

* fix migrate 7 uninstall script

* pre-merge issues addressed

* fix: add request id for the resource builder

* chore: bump package, update changes

* update to changes.md summary for 4.0.0

* chore: package lock update

* removing public schema from migration scripts

* updated version number in package.json and added 4.0.1 entry to changes

* support search teams in udaru core

* search team endpoint and search logic updates

* add total to team search response

* update search response validation to match actual response data

* Nested Teams Endpoint (#477)

* add nested teams to udaru core

* add nested endpoint

* add e2e test for nested team limit

* updating version and changes.md, updated pbac to 0.3.0

* use the buildParams directly to create base resource for user requests

* return 404 if nested team is not found

* Reset version to 4.0.1, it had accidently been set to 4.2.0

* check if team exists before returning users, check if user exist before return teams

* fix typo

* Example extended to demonstrate teams (#483)

* Support in udaru core for searching users (#463)

* Support in udaru core for searching users

* Linting fix

* Added some sanity check sql injection tests

* Linting fix (again)

* Linting fix (again again)

* expose public user search route

* add search users in a team

* Updated end to end testing for teams search and team users search

* updated version and changes

* updated changes.md 4.1.0 date

* Migration to nearForm SQL module

* Removed postgrator

* Removed postgrator

* Split code into 4 packages using lerna.

* packages/udaru/ -> packages/udaru-core/

* update version in changes.md, packages and static swagger docs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants