Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove serde from near-client-primitives. #5515

Merged
merged 4 commits into from
Nov 29, 2021
Merged

Remove serde from near-client-primitives. #5515

merged 4 commits into from
Nov 29, 2021

Conversation

pmnoxx
Copy link
Contributor

@pmnoxx pmnoxx commented Nov 29, 2021 •
edited
Loading

We should remove serde from near-client-primitives. It's only needed by jsonrpc.
More changes will be required, to separate jsonrpc api, from rest of the code base, but that's a first step.

See #5516

Blocks #5428 (review)

This was referenced Nov 29, 2021
Open
Merged
@pmnoxx pmnoxx force-pushed the piotr-remove-serde-from-near-client-primitives branch from 397ad81 to 5ef8081 Compare November 29, 2021 02:03
@pmnoxx pmnoxx self-assigned this Nov 29, 2021
@pmnoxx pmnoxx added the P-low Priority: low label Nov 29, 2021
miraclx
miraclx suggested changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@miraclx miraclx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one little thing:

chain/jsonrpc-primitives/src/types/network_info.rs Outdated Show resolved Hide resolved
@pmnoxx
Copy link
Contributor Author

pmnoxx commented Nov 29, 2021

@miraclx I added Deserialize for consistency reasons.

@near-bulldozer near-bulldozer bot merged commit 4b68972 into master Nov 29, 2021
@near-bulldozer near-bulldozer bot deleted the piotr-remove-serde-from-near-client-primitives branch November 29, 2021 18:44
@pmnoxx pmnoxx added A-chain Area: Chain, client & related C-dependencies Category: Pull requests that update a dependency file C-housekeeping Category: Refactoring, cleanups, code quality labels Dec 5, 2021
near-bulldozer bot pushed a commit that referenced this pull request Dec 9, 2021
@pmnoxx
re: Rename active peer to connected peer terminology in near-network (
f8b6b3e 
#5428)

Change terminology used in `near-network` to be more accurate.

Currently we use `active peer` terminology to mean `connected peer`.
Unfortunately, that term is not self explanatory and leads to some confussion.

See #5424

Blocked by #5515
pmnoxx added a commit that referenced this pull request Dec 9, 2021
@pmnoxx
re: Rename active peer to connected peer terminology in near-network (
9b02437 
#5428)

Change terminology used in `near-network` to be more accurate.

Currently we use `active peer` terminology to mean `connected peer`.
Unfortunately, that term is not self explanatory and leads to some confussion.

See #5424

Blocked by #5515
@miraclx miraclx mentioned this pull request Dec 22, 2021
Merged
near-bulldozer bot pushed a commit that referenced this pull request Dec 22, 2021
@miraclx
chore: bump nearcore version to 0.11.0 (#5943)
65aa0e1 
Minified changelog:

- `near-account-id` has gained significant QOL and design improvements. #5575 #5581 #5660
- `near-client-primitives` was detached from the public jsonrpc API. `NetworkInfoResponse` is now directly flattened into `RpcNetworkInfoResponse`. #5428 #5515

And much more.. crates-0.10.0...crates-0.11.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matklad matklad matklad left review comments

@miraclx miraclx miraclx approved these changes

@chefsale chefsale chefsale approved these changes

@khorolets khorolets Awaiting requested review from khorolets

Assignees

@pmnoxx pmnoxx

Labels
A-chain Area: Chain, client & related C-dependencies Category: Pull requests that update a dependency file C-housekeeping Category: Refactoring, cleanups, code quality P-low Priority: low
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmnoxx @matklad @chefsale @miraclx