Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PeerManagerActor rename active_peers to connected_peers #5424

Closed
pmnoxx opened this issue Nov 22, 2021 · 1 comment
Closed

PeerManagerActor rename active_peers to connected_peers #5424

pmnoxx opened this issue Nov 22, 2021 · 1 comment

Comments

@pmnoxx
Copy link
Contributor

pmnoxx commented Nov 22, 2021

Currently, we use term active peer inside PeerManagerActor. Based on our discussion
#5230 (comment) the usage of this term is confusing.

In PeerManagerActor active_peers refers to connected peers, or peers that we are in process of being connected.

I propose we rename active peer terminology to connected_peer.
@pmnoxx pmnoxx self-assigned this Nov 22, 2021
@pmnoxx pmnoxx mentioned this issue Nov 22, 2021
Merged
7 tasks
@frol frol mentioned this issue Nov 23, 2021
Merged
near-bulldozer bot pushed a commit that referenced this issue Dec 9, 2021
@pmnoxx
re: Rename active peer to connected peer terminology in near-network (
f8b6b3e 
#5428)

Change terminology used in `near-network` to be more accurate.

Currently we use `active peer` terminology to mean `connected peer`.
Unfortunately, that term is not self explanatory and leads to some confussion.

See #5424

Blocked by #5515
pmnoxx added a commit that referenced this issue Dec 9, 2021
@pmnoxx
re: Rename active peer to connected peer terminology in near-network (
9b02437 
#5428)

Change terminology used in `near-network` to be more accurate.

Currently we use `active peer` terminology to mean `connected peer`.
Unfortunately, that term is not self explanatory and leads to some confussion.

See #5424

Blocked by #5515
@stale
Copy link

stale bot commented Feb 20, 2022

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Feb 20, 2022
@pmnoxx pmnoxx removed their assignment Mar 7, 2022
@pmnoxx pmnoxx closed this as completed Mar 7, 2022
@stale stale bot removed the S-stale label Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pmnoxx