Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re: Rename active peer to connected peer terminology in near-network #5428

Merged
merged 5 commits into from
Dec 9, 2021
Merged

re: Rename active peer to connected peer terminology in near-network #5428

merged 5 commits into from
Dec 9, 2021

Conversation

pmnoxx
Copy link
Contributor

@pmnoxx pmnoxx commented Nov 23, 2021 •
edited
Loading

Change terminology used in near-network to be more accurate.

Currently we use active peer terminology to mean connected peer.
Unfortunately, that term is not self explanatory and leads to some confussion.

See #5424

Blocked by #5515

@pmnoxx pmnoxx self-assigned this Nov 23, 2021
frol
frol approved these changes Nov 23, 2021
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving to unblock the PR, but it is important to address the backward compatibility comment

chain/client-primitives/src/types.rs Show resolved Hide resolved
@pmnoxx pmnoxx added the P-medium Priority: medium label Nov 23, 2021
mm-near
mm-near previously requested changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@mm-near mm-near left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make sure that backwards compatibility is fixed before proceeding with this PR

@pmnoxx pmnoxx marked this pull request as draft November 29, 2021 01:42
@pmnoxx pmnoxx mentioned this pull request Nov 29, 2021
Merged
near-bulldozer bot pushed a commit that referenced this pull request Nov 29, 2021
@pmnoxx
Remove serde from near-client-primitives. (#5515)
4b68972 
We should remove `serde` from `near-client-primitives`. It's only needed by `jsonrpc`. 
More changes will be required, to separate `jsonrpc` api, from rest of the code base, but that's a first step.

See #5516

Blocks #5428 (review)
@pmnoxx pmnoxx marked this pull request as ready for review December 1, 2021 10:41
@pmnoxx pmnoxx force-pushed the piotr-rename-active-peer-connected-peer branch from e12c9df to 4c25088 Compare December 1, 2021 10:41
@pmnoxx pmnoxx requested a review from miraclx as a code owner December 1, 2021 10:41
@pmnoxx pmnoxx requested a review from mm-near December 1, 2021 10:41
@pmnoxx pmnoxx dismissed mm-near’s stale review December 1, 2021 10:42

Can you take a look again?

@pmnoxx pmnoxx added S-automerge A-network Area: Network C-docs Category: documentation, including rustdoc, nomicon, and docs.nearprotocol.com C-enhancement Category: An issue proposing an enhancement or a PR with one. C-epic Category: an epic and removed C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Dec 1, 2021
@pmnoxx pmnoxx requested a review from mina86 as a code owner December 8, 2021 21:12
@pmnoxx pmnoxx force-pushed the piotr-rename-active-peer-connected-peer branch from 608e299 to 4c25088 Compare December 9, 2021 09:17
@pmnoxx pmnoxx force-pushed the piotr-rename-active-peer-connected-peer branch from 4c25088 to 5af01ea Compare December 9, 2021 18:41
@near-bulldozer near-bulldozer bot merged commit f8b6b3e into master Dec 9, 2021
@near-bulldozer near-bulldozer bot deleted the piotr-rename-active-peer-connected-peer branch December 9, 2021 20:24
pmnoxx added a commit that referenced this pull request Dec 9, 2021
@pmnoxx
re: Rename active peer to connected peer terminology in near-network (
9b02437 
#5428)

Change terminology used in `near-network` to be more accurate.

Currently we use `active peer` terminology to mean `connected peer`.
Unfortunately, that term is not self explanatory and leads to some confussion.

See #5424

Blocked by #5515
@miraclx miraclx mentioned this pull request Dec 22, 2021
Merged
near-bulldozer bot pushed a commit that referenced this pull request Dec 22, 2021
@miraclx
chore: bump nearcore version to 0.11.0 (#5943)
65aa0e1 
Minified changelog:

- `near-account-id` has gained significant QOL and design improvements. #5575 #5581 #5660
- `near-client-primitives` was detached from the public jsonrpc API. `NetworkInfoResponse` is now directly flattened into `RpcNetworkInfoResponse`. #5428 #5515

And much more.. crates-0.10.0...crates-0.11.0
@frol frol mentioned this pull request May 20, 2022
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

@chefsale chefsale chefsale approved these changes

@miraclx miraclx miraclx approved these changes

@mm-near mm-near mm-near approved these changes

@bowenwang1996 bowenwang1996 Awaiting requested review from bowenwang1996

@khorolets khorolets Awaiting requested review from khorolets

@mzhangmzz mzhangmzz Awaiting requested review from mzhangmzz

@yordanmadzhunkov yordanmadzhunkov Awaiting requested review from yordanmadzhunkov

@mina86 mina86 Awaiting requested review from mina86

Assignees

@pmnoxx pmnoxx

Labels
A-network Area: Network C-docs Category: documentation, including rustdoc, nomicon, and docs.nearprotocol.com C-epic Category: an epic P-medium Priority: medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pmnoxx @frol @chefsale @miraclx @mm-near