-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update app to use a single endpoint for google and non-google stored brews #2089
Conversation
# Conflicts: # package-lock.json
Ok, so.... this all looks to be in order? 🎉 I haven't tested it yet but all your changes make sense. That's a lot of logic to shuffle around so I applaud your work. Just those couple small suggestions above and I'll test it a bit on my own, but looks pretty good to me! Also, make sure your NPM version is updated, and the dependencies are up-to-date as well. The |
Switched my node version to 16.14.0, seems to use the package-lock v2 now. Should be good for testing! |
This all seems to work after testing. I'll go ahead and merge this. 🤞 One small edge case that I'll make a separate issue for: since this keeps the same IDs between Google Drive/ Homebrewery when transferring the file, it's possible to end up with a |
I'm thinking maybe the Homebrew API methods that are LocalBrew and GoogleBrew might could be moved out of the api file and put in their own file, but that's really the only thing I'm still thinking about. Otherwise I think this is good to go!
See #2019