[WIP] Create Base Page structure - EditorPage

[G-Ambatte]

This PR is to implement underlying base pages, which are then called by the unique pages that require that format (i.e. /user draws from a base EditorPage prototype).

This will prevent duplication of effort - when the function is updated in the underlying page, all derived pages are updated.

• EditorPage base page
• NewPage implements EditorPage
  • Save works
  • Google Drive selection works
  • Print works
• EditPage implements EditorPage
  • Save works
  • Google Drive selection works
  • Print works
• Split functions from if(isType()){...} to callbacks from calling page
  • Print
  • NavElements
    • Include Print in NavElements?
  • Save/Autosave
    • NewPage - error handling NYI
    • EditPage
  • Transfer to/from Google Drive/HB MongoDB - EditPage only

This will resolve #1800.

[G-Ambatte]

I believe this is now functional, so it's probably time to get an extra set of eyes on it to see if I've missed anything.

[G-Ambatte]

I have split the Print and NavElements from the isNew()/isEdit() blocks inside the EditorPage functions to instead use props passed to EditorPage. At this stage, this has caused some issues with the Share links after transferring to/from Google Drive/Mongo, but I expect that this will be resolved once the final steps are completed.

Functions to split added to top post.

[calculuschild]

@G-Ambatte Do you need help knocking this one out?

[dbolack-ab]

Is this still a going concern and given its age, does it need redone from master?

[calculuschild]

Is this still a going concern and given its age, does it need redone from master?

Yeah it still needs to happen (we have a lot of redundancy that means multiple points need to be updated when fixing an issue with the editor, and its easy to miss one.)

But yeah needs to be done fresh from Master. A lot has changed since then.

[dbolack-ab]

Does this solve for #1413 as it's predecessor was supposed to?

[calculuschild]

Does this solve for #1413 as it's predecessor was supposed to?

This PR was never completed and so was not merged.

[dbolack-ab]

What remains for this?

[calculuschild]

What remains for this?

Basically needs to be redone from scratch at this point. Too many changes since this was originally made.

[5e-Cleric]

I have wanted to do this for a while, but every time i start it becomes really overwhelming, really fast. Too many features, and they should all be done together, in my opinion. Also lots of baggage from older react versions and that.

[dbolack-ab]

What remains for this?

Basically needs to be redone from scratch at this point. Too many changes since this was originally made.

Would it be best, then to close this and create a feature branch to target with smaller PRs until it completes?

[calculuschild]

Yeah, I will close this one and we can attempt with smaller PRs.

Before attempting again, let's please discuss a strategy in #1800 and outline some PR targets (at least the first couple), so we can ensure the main branch remains functional as we gradually merge each chunk.