Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify base page structure - EditorPage #1800

Open
G-Ambatte opened this issue Nov 4, 2021 · 0 comments
Open

Unify base page structure - EditorPage #1800

G-Ambatte opened this issue Nov 4, 2021 · 0 comments
Assignees
Labels
Approved Has been discussed and an approach is agreed upon P1 - high priority Obvious bug or popular features

Comments

@G-Ambatte
Copy link
Collaborator

#1423 was an attempt to unify the underlying editor page for NewPage and EditPage. However the rest of the project moved on before the PR was completed.

This issue is to record the idea - unifying the underlying page structure so that functions do not need to be modified in multiple places - so that it is not lost with the closure of #1423.

My intention is to close #1423 and open a new PR with a smaller, sleeker set of changes, implementing a minimal combined EditorPage to be called by NewPage and EditPage, which can be merged further through later PRs.
I also intend to push UserPage through an underlying ListPage, which can be used for any future pages that need to list multiple brews.


This issue is to track to the creation and progress of the EditorPage base page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Has been discussed and an approach is agreed upon P1 - high priority Obvious bug or popular features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants