[DataGrid] Fix deselection not working with isRowSelectable
#15692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MBilalShafi
added
bug 🐛
|
Deploy preview: https://deploy-preview-15692--material-ui-x.netlify.app/ Updated pages: |
cherniavskii
approved these changes
Dec 2, 2024
KenanYusuf
approved these changes
Dec 3, 2024
KenanYusuf
reviewed
Dec 3, 2024
arminmeh
approved these changes
Dec 3, 2024
docs/data/migration/migration-data-grid-v7/migration-data-grid-v7.md
Outdated
Show resolved
Hide resolved
packages/x-data-grid/src/components/columnSelection/GridHeaderCheckbox.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Armin Mehinovic <4390250+arminmeh@users.noreply.github.com> Co-authored-by: Kenan Yusuf <kenan.m.yusuf@gmail.com> Signed-off-by: Bilal Shafi <bilalshafidev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15676
This fix comes with a behavioral change.
Previous Behavior: When some rows were marked as "not selectable" using
isRowSelectable, the "select all" checkbox could never be checked, it's always in "indeterminate" mode even if all the "selectable" rows are checked.Updated Behavior: "Select all" checkbox status is based on the selectable rows only. When all the selectable rows are checked, "select all" checkbox will be checked even if there are a few unselectable rows not checked.
Found similar behavior with some other libraries, examples:
ToDos:
Changelog
Breaking changes
isRowSelectableprop.