Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Cannot deselect all rows when isRowSelectable is used #15676

Closed
cherniavskii opened this issue Nov 29, 2024 · 2 comments · Fixed by #15692
Closed

[DataGrid] Cannot deselect all rows when isRowSelectable is used #15676

cherniavskii opened this issue Nov 29, 2024 · 2 comments · Fixed by #15692
Assignees
@MBilalShafi
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature v8.x

Comments

@cherniavskii
Copy link
Member

cherniavskii commented Nov 29, 2024 •
edited by github-actions bot
Loading

Steps to reproduce

Steps:

  1. Open this link to live example: https://codesandbox.io/p/sandbox/cocky-sun-y2yvjm
  2. Click "Select all" checkbox
  3. Click the same checkbox to deselect all rows

Current behavior

Selected rows stay selected

Expected behavior

All rows should be deselected

Context

I noticed this while working on #15651

Your environment

npx @mui/envinfo 
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: deselect all isRowSelectable
@cherniavskii cherniavskii added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature v8.x labels Nov 29, 2024
@cherniavskii
Copy link
Member Author

cc @MBilalShafi

@MBilalShafi MBilalShafi self-assigned this Nov 29, 2024
@MBilalShafi MBilalShafi mentioned this issue Dec 2, 2024
Merged
2 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MBilalShafi MBilalShafi

Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature v8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Fix deselection not working with isRowSelectable MBilalShafi/mui-x
2 participants
@MBilalShafi @cherniavskii