Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix deselection not working with isRowSelectable #15692

Merged
merged 9 commits into from
Dec 3, 2024
Merged

[DataGrid] Fix deselection not working with isRowSelectable #15692

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b3809a9
[DataGrid] Fix deselection not working with isRowSelectable
MBilalShafi Dec 1, 2024
b95315b
Lint
MBilalShafi Dec 2, 2024
e1a4941
Merge branch 'master' into bugfix/15676
MBilalShafi Dec 2, 2024
4824f72
Add test
MBilalShafi Dec 3, 2024
fe8e3d2
Add to migration guide
MBilalShafi Dec 3, 2024
c6404b2
Merge branch 'master' into bugfix/15676
MBilalShafi Dec 3, 2024
4e5cb8d
Apply Kenan and Armin's suggestions
MBilalShafi Dec 3, 2024
3d25ab4
Fix types issue
MBilalShafi Dec 3, 2024
14060bd
Merge branch 'master' into bugfix/15676
MBilalShafi Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/x-data-grid/src/components/columnSelection/GridHeaderCheckbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,15 @@ const GridHeaderCheckbox = React.forwardRef<HTMLButtonElement, GridColumnHeaderP
// Convert to an object to make O(1) checking if a row exists or not
// TODO create selector that returns visibleRowIds/paginatedVisibleRowIds as an object
return rowIds.reduce<Record<GridRowId, true>>((acc, id) => {
const isSelectable = apiRef.current.isRowSelectable(id);
if (!isSelectable) {
MBilalShafi marked this conversation as resolved.
Show resolved Hide resolved
return acc;
}
acc[id] = true;
return acc;
}, {});
}, [
apiRef,
rootProps.pagination,
rootProps.checkboxSelectionVisibleOnly,
paginatedVisibleRowIds,
Expand Down