[Core] Update to React v15

[nathanmarks]

Worked my way through the docs to fix React v15 compatibility. Updated dependencies.

Anyone want to update the examples? 😄

some relevant issues I made while doing this:
Fixes #3940
Fixes #3942
Fixes #3943
Fixes #3945

@callemall/material-ui holler

[nathanmarks]

Also... can someone test if this works with React 14? I left it as an option in peer dependencies...

[newoga]

Do these have 15.0.0 equivalents?

     "react-addons-create-fragment": "^0.14.0",
     "react-addons-transition-group": "^0.14.0",
     "react-addons-update": "^0.14.0",

Edit: Nvm, I guess it doesn't matter since they are dependencies instead of peerDependencies. What do you think?

[newoga]

Do we need to upgrade recompose to 0.17.0 too (0.16.0 added React 15 compatibility)? Once again, not sure if it matters for dependency.

[nathanmarks]

@newoga yep I should update these:

$ ncu

 react-addons-create-fragment   ^0.14.0  →  ^15.0.1
 react-addons-transition-group  ^0.14.0  →  ^15.0.1
 react-addons-update            ^0.14.0  →  ^15.0.1
 recompose                      ^0.15.0  →  ^0.17.0

Run with -u to upgrade package.json

[nathanmarks]

@oliviertassinari

I removed the peer dependencies for the older react version as we depend on react addons that we have upgraded to the v15 versions. In their package.json files they have react ^15.0.1 as a peer dependency... Also, the tap event plugin has a peer dependency on react 15+.

I spoke to @newoga and we're not sure what the best/most compatible setup is here that we can go with. We were hoping you might know some more about this 😄

IMO, we should avoid breaking 0.14.x if possible, but not go out of our way to support it... but with the peer dependencies is this even possible (without fuss) with the other libs/addons we use?

[newoga]

@nathanmarks I think @oliviertassinari has a new version of react-swipeable-views we can put in docs for material 15.0.0. Could you run a quick ncu on docs to see if there is any other react related dep that we should update (I think that should be it though).

[newoga]

Looks good to me 👍

[oliviertassinari]

I have noticed that the Customization section of the docs is throwing a lot of warnings.

[nathanmarks]

@antoinerousseau yep

[nathanmarks]

@oliviertassinari thanks, completely forgot to cover that section.

shit like this:

lol

[nathanmarks]

@oliviertassinari fixed the silly docs errors 😄 👍

[oliviertassinari]

@nathanmarks Nice work 👍.

[phanindra48]

This is resulting to NaN when thumbStyles width is set to something like '10px'!

[oliviertassinari]

Sounds like a fair point. Do you want to submit a PR to fix it?

[oliviertassinari]

Actually, my suggestion won't work. It's raising a warning:

Warning: a div tag (owner: Paper) was passed a numeric string value for CSS property marginLeft (value: -20) which will be treated as a unitless number in a future version of React.

You gonna have to use 10 instead of 10px until we change the styling approach with the next branch.

[phanindra48]

Sorry for the late reply. But things will break right because of this inconsistency.
Hope this will help

0 - parseInt(`${thumbStyles.width}`.replace('px', ''), 10)

[phanindra48]

@oliviertassinari Raised a PR - #5116