Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Toggle] Bug fix in thumbStyle margin-left property #5116

Closed
wants to merge 1 commit into from
Closed

[Toggle] Bug fix in thumbStyle margin-left property #5116

wants to merge 1 commit into from

Conversation

phanindra48
Copy link

@phanindra48 phanindra48 commented Sep 2, 2016 •
edited
Loading

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@phanindra48 phanindra48 mentioned this pull request Sep 2, 2016
Merged
@phanindra48 phanindra48 changed the title Bug fix in thumbStyle margin-left property [Toggle] Bug fix in thumbStyle margin-left property Sep 2, 2016
@oliviertassinari oliviertassinari added on hold There is a blocker, we need to wait and removed PR: Needs Review labels Sep 13, 2016
@oliviertassinari
Copy link
Member

@phanindra48 Thanks for this PR. However, we shouldn't have to deal with this edge case in the first place. #5106 should address your issue.

@oliviertassinari oliviertassinari mentioned this pull request Sep 13, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
on hold There is a blocker, we need to wait
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phanindra48 @oliviertassinari @muibot