-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Ensure React v15 compatibility #3642
Comments
Yes! let there be |
Yea I seemed to run into some issues with the drop down menu specifically in my code. Issue #3634 Not mentioned in that issue that should probably be is the fact all touch events seem to not be firing (not just the dropdown) |
Hmmm I think that's an issue with the touch-tap-plugin. |
I'm also having issues with tabs and icon menus -- the clicks do the ripple effect but don't trigger any events. |
@bushmango @alitaheri @LordLambda There's some issues with React 15 and the tap event thing. |
SelectField not working with React 15 |
|
@ffxsam it's going to be a little while before a reasonable amount mobile phone users (esp android) are on the latest version |
A direct copied toolbar example is not working for me on React v15.0.1 Code copied directly from the toolbar example (http://www.material-ui.com/#/components/toolbar) looks like this: http://i.imgur.com/ToG2LKZ.jpg See this maybe: facebook/react#6221 I'm fairly new to Material UI and I'm not sure how to fix. |
@Connorelsea same reason as discussed above |
@ffxsam Actually I just realised that chrome has had it on android since version 32. Maybe we really can get rid of it.... gpbl/react-day-picker#153 |
A solution for the touch tap problem: Possible solution: Use the latest version of react-tap-event-plugin in your package.json. Unfortunately there is not yet a new release. "react-tap-event-plugin": "git+https://github.com/zilverline/react-tap-event-plugin.git" |
It has been released now: zilverline/react-tap-event-plugin#66 (comment) https://www.npmjs.com/package/react-tap-event-plugin @ShMcK using git urls in |
I'm having issues with tabs, I'm new to mui so I'm not sure if I am doing something wrong or is it related to this. I've taken a direct copy of the tab examples from the simple example here I've updated to release 1.0.0 of react-tap-event-plugin in my package.json The tabs display fine, they get coloured as if I click them (the grey shadow thing, the active tab indicator does not change) but It does not change the content Any suggestions? |
#3941 was just merged. Thanks @nathanmarks. |
@oliviertassinari do you have an ETA to publish to NPM this fix? My project is depending on Material-ui and this. I will downgrade react back to an older version if you say it might take some time. Thanks! |
@DanielHoffmann It has been on NPM for a long time now (1 year). |
@oliviertassinari Hm, that is weird, I thought my material-ui stopped working after I updated to the newest version of react, I thought the cause was this issue. I am using version 2.0.1 of this plugin and React 15.5.4 |
Hey @callemall/material-ui ,
We should make sure we support React v15 for the
0.15.0
release of mui. Has anyone had the chance yet to check out the lib with the release candidate?If anyone finds an issue that needs fixing, please add it here!
stuff that needs doing
The text was updated successfully, but these errors were encountered: