-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Hide password while Typing and after Entering: Fixes #670 #686
Conversation
fbadff3
to
a4ac918
Compare
@dannycoates Do you mind giving a review ? Its been 10 days |
With this latest commit, the set password is now toggleable, i.e., normally it is starred and on hover, the original password is displayed. @dannycoates Please review |
c5d5ba3
to
b0cd275
Compare
The code looks ok. @sevaan, what do you think about the design and hover to reveal? I think we should use ● (U+25CF) instead of * though. |
If that is the case, I'll do that right away. Is it fine otherwise ? |
Looks great! Good idea. And let's use U+25CF, it'll be much cleaner. Thanks! |
@dannycoates @sevaan I have made the required changes, here's a preview All the commits have been squashed too. Please review |
Changed * to ●
3bc6af9
to
8434312
Compare
Thanks @shikhar-scs 😄 |
Welcome @dannycoates 😄 |
As suggested by @dannycoates #673 all the requested changes have been made. Here's a preview
(its a gif file, please be patient while it loads)
Also Fixes #670
Please review