Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

Hide password while Typing and after Entering: Fixes #670 #686

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

shikhar-scs
Copy link
Contributor

@shikhar-scs shikhar-scs commented Dec 23, 2017

As suggested by @dannycoates #673 all the requested changes have been made. Here's a preview
(its a gif file, please be patient while it loads)
Also Fixes #670

ezgif com-video-to-gif

Please review

@shikhar-scs
Copy link
Contributor Author

the commit 3610670 actually references #679. I'll stash that here.

@shikhar-scs
Copy link
Contributor Author

@dannycoates Do you mind giving a review ? Its been 10 days

@claudijd claudijd mentioned this pull request Jan 2, 2018
@shikhar-scs
Copy link
Contributor Author

With this latest commit, the set password is now toggleable, i.e., normally it is starred and on hover, the original password is displayed.
Here's a preview for the same (its a gif file, please be patient while it loads)

sendpassword

@dannycoates Please review

@shikhar-scs shikhar-scs changed the title Hide password while Typing and after Entering , Closes #670 Hide password while Typing and after Entering: Fixes #670 Jan 3, 2018
@dannycoates
Copy link
Contributor

The code looks ok. @sevaan, what do you think about the design and hover to reveal? I think we should use ● (U+25CF) instead of * though.

@shikhar-scs
Copy link
Contributor Author

I think we should use ● (U+25CF) instead of * though.

If that is the case, I'll do that right away. Is it fine otherwise ?

@sevaan
Copy link

sevaan commented Jan 6, 2018

The code looks ok. @sevaan, what do you think about the design and hover to reveal? I think we should use ● (U+25CF) instead of * though.

Looks great! Good idea. And let's use U+25CF, it'll be much cleaner. Thanks!

@shikhar-scs
Copy link
Contributor Author

shikhar-scs commented Jan 6, 2018

@dannycoates @sevaan I have made the required changes, here's a preview

latest

All the commits have been squashed too. Please review

Changed * to ●
@dannycoates dannycoates merged commit 7b96c46 into mozilla:master Jan 8, 2018
@dannycoates
Copy link
Contributor

Thanks @shikhar-scs 😄

@shikhar-scs
Copy link
Contributor Author

Welcome @dannycoates 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants