Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

Commit

Permalink
Merge pull request #686 from shikhar-scs/hidePassword
Browse files Browse the repository at this point in the history
Hide password while Typing and after Entering: Fixes #670
  • Loading branch information
dannycoates committed Jan 8, 2018
2 parents 3d48ea7 + 8434312 commit 7b96c46
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 4 deletions.
18 changes: 17 additions & 1 deletion app/templates/share.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,23 @@ function passwordComplete(state, password) {
password: '<pre></pre>'
})}</div>`
]);
el.lastElementChild.textContent = password;
const displayPassword = [];
for (let i = 0; i < password.length; i++) {
displayPassword[i] = '●';
}

const passwordOriginal = document.createElement('div');
passwordOriginal.className = 'passwordOriginal';
passwordOriginal.innerText = password;

const passwordStar = document.createElement('div');
passwordStar.className = 'passwordStar';
passwordStar.innerText = displayPassword
.toString()
.split(',')
.join('');
el.lastElementChild.appendChild(passwordOriginal);
el.lastElementChild.appendChild(passwordStar);
return el;
}

Expand Down
5 changes: 2 additions & 3 deletions app/templates/uploadPassword.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@ module.exports = function(state, emit) {
const div = html`
<div class="selectPassword">
<div id="addPasswordWrapper">
<input id="addPassword" type="checkbox" autocomplete="off" onchange=${
togglePasswordInput
}/>
<input id="addPassword" type="checkbox" autocomplete="off" onchange=${togglePasswordInput}/>
<label for="addPassword">
${state.translate('requirePasswordCheckbox')}</label>
</div>
Expand All @@ -17,6 +15,7 @@ module.exports = function(state, emit) {
maxlength="64"
autocomplete="off"
placeholder="${state.translate('unlockInputPlaceholder')}"
type="password"
oninput=${inputChanged}/>
<input type="submit"
id="unlock-btn"
Expand Down
12 changes: 12 additions & 0 deletions assets/main.css
Original file line number Diff line number Diff line change
Expand Up @@ -666,6 +666,18 @@ tbody {
overflow-wrap: break-word;
}

.passwordOriginal {
display: none;
}

.selectPassword :hover .passwordOriginal {
display: block;
}

.selectPassword :hover .passwordStar {
display: none;
}

.setPassword {
align-self: left;
display: flex;
Expand Down

0 comments on commit 7b96c46

Please sign in to comment.