Mask password on upload #673
Conversation
|
Behavior change this is attempting to achieve is this... BEFORE
AFTER
Basically, make the password hidden while typing it in. |
|
After the password is set, we show a set state under the link. Currently, it includes the plain text password. I would be surprised if my hidden input was revealed after I click the button. So, if we want the input to be hidden, I think the display of the set state should be obscured by default as well but include an option to reveal it. |
|
@dannycoates , could I make these modifications or @claudijd are you still working on it? |
|
@himanish-star please, feel free to make the mods, I was just trying to help, but my JS isn't that strong. |
|
@claudijd , Thanks but shikhar has already filed the PR and I guess he's done it right |
|
Closing in favor of #686 |
When a user enters a password for a given file download, mask it so it doesn't show to someone looking over their shoulder. I also briefly looked into how to mask the echo'd password, which comes out in pre tags, but would love some advice on how to approach that. Advice is welcomed!