Use "full" localization ids in the PDFDocumentProperties class
#18663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
changed the title
PDFDocumentProperties class
It was recently brought to my attention that using partial or generated localization ids is bad for maintainability, which means that PR 18636 wasn't the correct thing to do. However, just reverting that one doesn't really fix the problems which is why this patch updates *every* l10n-id in the `PDFDocumentProperties` class (but doesn't touch any `viewer.ftl`-files). Obviously this leads to more verbose code, but that cannot really be helped.
With the introduction of Fluent the `getLanguage`-method became synchronous, hence it no longer seems necessary to do the metric-locale check eagerly in the constructor and it can instead be "delayed" until actually needed.
Snuffleupagus
force-pushed
the
PDFDocumentProperties-full-l10n-ids
branch
from
89a12ff
to
39ac3ef
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6bb090ef5bc9b11/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6bb090ef5bc9b11/output.txt Total script time: 1.10 mins Published |
timvandermeij
approved these changes
Aug 29, 2024
|
Looks good; thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "full" localization ids in the
PDFDocumentPropertiesclassIt was recently brought to my attention that using partial or generated localization ids is bad for maintainability, which means that PR Introduce a helper method for fetching l10n-data in
PDFDocumentProperties#18636 wasn't the correct thing to do.However, just reverting that one doesn't really fix the problems which is why this patch updates every l10n-id in the
PDFDocumentPropertiesclass (but doesn't touch anyviewer.ftl-files). Obviously this leads to more verbose code, but that cannot really be helped.Move the metric-locale check into
PDFDocumentProperties.#parsePageSizeWith the introduction of Fluent the
getLanguage-method became synchronous, hence it no longer seems necessary to do the metric-locale check eagerly in the constructor and it can instead be "delayed" until actually needed.