Introduce a helper method for fetching l10n-data in PDFDocumentProperties
#18636
Conversation
…rties` Given the length of the l10n-strings we can slightly reduce verbosity, and thus overall code-size, by introducing a helper method for fetching l10n-data. While testing this I stumbled upon an issue in the `L10n`-class, where an optional chaining operator was placed incorrectly since the underlying method always return an Array; see https://github.com/projectfluent/fluent.js/blob/48e2a62ed45ff2a62a231b2e83cfd8b332d27acb/fluent-dom/src/localization.js#L38-L77
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/069f7e7e5997b4c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/cda5e5ca89ff9ef/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/069f7e7e5997b4c/output.txt Total script time: 8.77 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/cda5e5ca89ff9ef/output.txt Total script time: 19.99 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/070f945086ce3e2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/070f945086ce3e2/output.txt Total script time: 1.03 mins Published |
|
Thanks! |
Given the length of the l10n-strings we can slightly reduce verbosity, and thus overall code-size, by introducing a helper method for fetching l10n-data.
While testing this I stumbled upon an issue in the
L10n-class, where an optional chaining operator was placed incorrectly since the underlying method always return an Array; see https://github.com/projectfluent/fluent.js/blob/48e2a62ed45ff2a62a231b2e83cfd8b332d27acb/fluent-dom/src/localization.js#L38-L77