Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a helper method for fetching l10n-data in PDFDocumentProperties #18636

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Introduce a helper method for fetching l10n-data in PDFDocumentProperties #18636

merged 1 commit into from
Aug 23, 2024

Commits on Aug 21, 2024

  1. Introduce a helper method for fetching l10n-data in `PDFDocumentPrope… 

    …rties`

Given the length of the l10n-strings we can slightly reduce verbosity, and thus overall code-size, by introducing a helper method for fetching l10n-data.

While testing this I stumbled upon an issue in the `L10n`-class, where an optional chaining operator was placed incorrectly since the underlying method always return an Array; see https://github.com/projectfluent/fluent.js/blob/48e2a62ed45ff2a62a231b2e83cfd8b332d27acb/fluent-dom/src/localization.js#L38-L77
    @Snuffleupagus
    Snuffleupagus committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    2c34b64 View commit details
    Browse the repository at this point in the history