Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "full" localization ids in the PDFDocumentProperties class #18663

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Use "full" localization ids in the PDFDocumentProperties class #18663

merged 2 commits into from
Aug 29, 2024

Commits on Aug 29, 2024

  1. Use "full" localization ids in the PDFDocumentProperties class 

    It was recently brought to my attention that using partial or generated localization ids is bad for maintainability, which means that PR 18636 wasn't the correct thing to do.
However, just reverting that one doesn't really fix the problems which is why this patch updates *every* l10n-id in the `PDFDocumentProperties` class (but doesn't touch any `viewer.ftl`-files). Obviously this leads to more verbose code, but that cannot really be helped.
    @Snuffleupagus
    Snuffleupagus committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    a6e5416 View commit details
    Browse the repository at this point in the history

  2. Move the metric-locale check into PDFDocumentProperties.#parsePageSize 

    With the introduction of Fluent the `getLanguage`-method became synchronous, hence it no longer seems necessary to do the metric-locale check eagerly in the constructor and it can instead be "delayed" until actually needed.
    @Snuffleupagus
    Snuffleupagus committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    39ac3ef View commit details
    Browse the repository at this point in the history