Fix misspecified tests using MagicMock().called_with() #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Prior implementation ran `assert ...MagicMock.called_with(...)` `called_with` is not a real test method on MagicMock, so it returns a MagicMock instance by default, which is truthy and evaluates to true by assert. This test wasn't checking for anything and would pass no matter what actually happened in the code. These new tests check for the intended methods being called.
austinweisgrau
force-pushed
the
fix_twilio_tests
branch
from
b5de776
to
8729c8d
Compare
austinweisgrau
changed the title
shaunagm
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1071
The tests which use this method must be rewritten - some of them fail once the misspecified method is fixed, and will need to be rewritten to actually test what they intend to test.
TO DO:
called_with()BLOCKING: