-
Notifications
You must be signed in to change notification settings - Fork 132
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix misspecified tests using MagicMock().called_with() (#1072)
* Fix misspecified twilio tests Prior implementation ran `assert ...MagicMock.called_with(...)` `called_with` is not a real test method on MagicMock, so it returns a MagicMock instance by default, which is truthy and evaluates to true by assert. This test wasn't checking for anything and would pass no matter what actually happened in the code. These new tests check for the intended methods being called. * Fix misspecified salesforce tests * Fix misspecified test guidelines in docs
- Loading branch information
1 parent
061bb89
commit c49f631
Showing
3 changed files
with
37 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters