Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misspecified tests using MagicMock().called_with() #1072

Merged
merged 3 commits into from
Jun 25, 2024

Commits on Jun 21, 2024

  1. Fix misspecified twilio tests

    Prior implementation ran `assert ...MagicMock.called_with(...)`
    
    `called_with` is not a real test method on MagicMock, so it returns a
    MagicMock instance by default, which is truthy and evaluates to true
    by assert. This test wasn't checking for anything and would pass no
    matter what actually happened in the code.
    
    These new tests check for the intended methods being called.
    austinweisgrau committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    8729c8d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c77452e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d28cfe9 View commit details
    Browse the repository at this point in the history