MessageId should be unassigned in queue #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcollina May we add collaborators for this project? any more we should add? |
This was referenced Jul 18, 2019
|
What's the status of this? |
|
(CI is failing) |
outgoingEnqueue and outgoingEnqueueCombi functions should not store messageId. outgoingUpdate function will do. This PR requires moscajs/aedes-packet#5
gnought
force-pushed
the
hotfix/messageid_undefined_as_default_qos_gt_0
branch
from
4d13522
to
af4f20a
Compare
|
The CI passed after we use aedes-packet v2.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
outgoingEnqueueandoutgoingEnqueueCombifunctions should not store messageId.outgoingUpdatefunction will do. This PR requires moscajs/aedes-packet#5