Added a unit test, check offline queue in QoS 1 #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnought
force-pushed
the
hotfix/qos1_offline_queue
branch
from
f7f9edc
to
64c10c3
Compare
|
Would you mind to bump aedes persistence? |
|
The CI test will pass after merging moscajs/aedes-persistence#33 |
|
And this PR also requires moscajs/aedes-persistence#32, otherwise aedes will not properly call emptyQueue |
Closed
The items in offline queue should be same as what we inserted
gnought
force-pushed
the
hotfix/qos1_offline_queue
branch
from
b146a33
to
54e5d35
Compare
gnought
changed the title
|
Are we ready for a release of Aedes? Would you mind sending PRs to the redis and mongodb persistences updating them? |
|
Which part do you want to update aedes-persistence-redis and aedes-persistence-mongodb? |
|
I prefer to review the changes
Il giorno mar 6 ago 2019 alle 17:27 Gnought <notifications@github.com> ha
scritto:
… Which part do you want to update aedes-persistence-redis and
aedes-persistence-mongodb?
Still have some PR on hands. The release could go fast if we agree on
directly making changes in master branch. :)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#264>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAMXY7BH34UZ3LFEYVPR3DQDGJ7LANCNFSM4IEBC6EQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The items in offline queue should be same as what we inserted.
However it is related to aedes-persistence. The PR moscajs/aedes-persistence#31 will fix the CI test.