Set messageid be undefined in qos > 0 or non-publish command #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will fail the CI test in aedes and aedes-persistence. |
gnought
added a commit
to gnought/aedes-persistence
that referenced
this pull request
Jul 17, 2019
outgoingEnqueue and outgoingEnqueueCombi functions should not store messageId. outgoingUpdate function will do. This PR requires moscajs/aedes-packet#5
gnought
added a commit
to gnought/aedes-persistence
that referenced
this pull request
Jul 17, 2019
outgoingEnqueue and outgoingEnqueueCombi functions should not store messageId. outgoingUpdate function will do. This PR requires moscajs/aedes-packet#5
|
@mcollina May we add collaborators for this project? any more we should add? |
gnought
added a commit
to gnought/aedes-persistence
that referenced
this pull request
Jul 29, 2019
outgoingEnqueue and outgoingEnqueueCombi functions should not store messageId. outgoingUpdate function will do. This PR requires moscajs/aedes-packet#5
mcollina
pushed a commit
to moscajs/aedes-persistence
that referenced
this pull request
Jul 29, 2019
* Added collaborators * Add coverage & license check, format lint output * Update .gitignore * Added more badges * MessageId should be unassigned in queue outgoingEnqueue and outgoingEnqueueCombi functions should not store messageId. outgoingUpdate function will do. This PR requires moscajs/aedes-packet#5 * Update .gitignore * Update dependencies * Add more badges in README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for issue #4
Mainly we need to let
QoSPacketin aedes could be assigned a correct messageId indeliverQoSfunctionhttps://github.com/mcollina/aedes/blob/master/lib/client.js#L118
https://github.com/mcollina/aedes/blob/master/lib/qos-packet.js#L11