update mb-sessions, add unit tests #141
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Config
instead of imported from the runtime (so still configured in the runtime, just in a more intuitive location)TODO (in-progress)
mb-session
Treasury
storage item and also remove theVec<AccountId>
for validators to useIterableStorageMap
api instead to get the same functionality without the additional storage itemWhat important points reviewers should know?
I changed the
crypto
module inmb-sessions
to only usesp_core::ecdsa
as per the changes in #127 (I made this change in this commit: d732df2 ).Is there something left for follow-up PRs?
I'll add unit tests to the other pallets as well. It is a good exercise for reviewing the runtime code.
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?
Adding unit tests to each pallet allow us to isolate and catch errors in the runtime instead of relying on integration testing or production to alert us after the fact.
Checklist