Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mb-sessions, add unit tests #141

Closed
wants to merge 9 commits into from
Closed

update mb-sessions, add unit tests #141

wants to merge 9 commits into from

Commits on Dec 16, 2020

  1. init so mb-session compiles, locally

    @4meta5
    4meta5 committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    e11e8c0 View commit details
    Browse the repository at this point in the history

  2. rename Trait to Config for mb-session

    @4meta5
    4meta5 committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    c71e523 View commit details
    Browse the repository at this point in the history

  3. add explicit Endorsement Type to improve code readability

    @4meta5
    4meta5 committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    0e0ff97 View commit details
    Browse the repository at this point in the history

  4. set_snapshot is infallible so it should not return DispatchResult

    @4meta5
    4meta5 committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    b0a9c24 View commit details
    Browse the repository at this point in the history

  5. replace ).map_err(Into::into) with .into()) in sessions for looks

    @4meta5
    4meta5 committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    5f72971 View commit details
    Browse the repository at this point in the history

  6. rm unnecessary pub fields for Endorsement type and use frame_support:… 

    …:ensure macro, equivalent to if return
    @4meta5
    4meta5 committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    a4d14ad View commit details
    Browse the repository at this point in the history

  7. add Snapshot type to improve code readability

    @4meta5
    4meta5 committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    942f7be View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. make ValidatorsPerSession and EpochDuration module constants, still t… 

    …o be configured in the runtime like the previous import structure
    @4meta5
    4meta5 committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    2138011 View commit details
    Browse the repository at this point in the history

  2. mock runtime impl to init mb-session unit testing

    @4meta5
    4meta5 committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    d732df2 View commit details
    Browse the repository at this point in the history