Remove MultiSignature #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joelamouche I've done as much as I can for now here. I'll need you to tell me whether this works with Polkadot JS, or what else I need to do on it. |
|
Everything seems to be working. How do I provision an account with tokens to test transfer? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@JoshOrndorff I corrected the type on this branch https://github.com/joelamouche/apps/tree/jlm-update-moonbeam-types and all the transfers work now. I added "[u8; 65]" type for the Ethereum signature, which is the ecdsa signature format. Please test and let me know if it works for you so that I can submit the PR |
This comment has been minimized.
This comment has been minimized.
4meta5
reviewed
Dec 14, 2020
Co-authored-by: Amar Singh <asinghchrony@protonmail.com>
3 tasks
3 tasks
|
I think this could be merged once green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Changes the Moonbeam Runtime's signature type from a
MultiSignatureto justEthereumSignature.What important points reviewers should know?
The main reason we had Multisignature was for compatability with Polkadot JS which expected Multisignature in the past. Now that PolkadotJS is flexible to support this single signature type, we should use it.
Is there anything left for Followups
The one thing that doesn't appear working is the display of token balances in Apps.
I'm not sure whether this is new with this PR, or pre-existing.Confirmed this issue exists in master and was not introduced by this PR. So this is good to go.Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
MOON-117 - tracking issue
polkadot-js/api#2845 - Jaco adds ability to no use MultiSignature
polkadot-js/apps#4151 - Antoine adds our updated types
What value does it bring to the blockchain users?
It is a minor detail in the unified accounts story. We want Ethereum-style H160 accounts to be the one and only notion of account on Moonbeam
Checklist