Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove moment dependency #149

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Remove moment dependency #149

merged 1 commit into from
Mar 16, 2018

Conversation

anqqa
Copy link

@anqqa anqqa commented Mar 16, 2018

Moment.js was used to build new Date objects even though we could use native Date object directly. Saves around 51 kB in the final JS bundle when building the React Native app.

Closes #125

@mmazzarolo
Copy link
Owner

Great! Thank you anqqa! Merged.

@mmazzarolo mmazzarolo merged commit 7afa366 into mmazzarolo:master Mar 16, 2018
@mmazzarolo
Copy link
Owner

Landed in v5.0.0

@mmazzarolo mmazzarolo mentioned this pull request Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants