Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate moment #125

Closed
Andreyco opened this issue Jan 3, 2018 · 2 comments
Closed

Deprecate moment #125

Andreyco opened this issue Jan 3, 2018 · 2 comments
Labels
enhancement

Comments

@Andreyco
Copy link

Andreyco commented Jan 3, 2018

Looking at code, moment lib is used to extract hour of of the date.
Using moment brought several issues is past and is not necessary in this time.

If you, maintainers, are open for such change, I am willing to submit PR.
@mmazzarolo
Copy link
Owner

@Andreyco more than open to a new PR. Thanks!

@mmazzarolo mmazzarolo mentioned this issue Jan 4, 2018
Closed
@mmazzarolo
Copy link
Owner

Hey @Andreyco, any progress on this? 👍

@anqqa anqqa mentioned this issue Mar 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Andreyco @mmazzarolo