Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong time. #151

Closed
MihaiSandor opened this issue Apr 2, 2018 · 10 comments
Closed

Wrong time. #151

MihaiSandor opened this issue Apr 2, 2018 · 10 comments
Labels

Comments

@MihaiSandor
Copy link

MihaiSandor commented Apr 2, 2018

The outcome of the react-native-modal-datetime-picker swap described above - react-native-datetime-picker (latest)
iOS 11.3 (Iphone X simulator)
What version of react-native-modal-datetime-picker? - latest
What packages or other dependencies you're using? - just react-native-modal-datetime-picker and React Native.
An isolated way to reproduce the behavior (example: GitHub repository with code isolated to the issue that anyone can clone to observe the problem) - I don't know.
The behavior you expect to see, and the actual behavior? See below
screen shot 2018-04-02 at 13 49 37
I chose the current time and it came back 3 hours ago.

1:58 current time
10:58 returned

@mmazzarolo
Copy link
Owner

When reporting a bug, please be sure to check if the issue still persists with react-native original date/time pickers:

Under the hood react-native-modal-datetime-picker uses react-native original DatePickerAndroid, TimePickerAndroid and DatePickerIOS.
Before reporting a bug, try swapping react-native-datetime-picker with react-native original date/time pickers to check if the problem persists.

When reporting a bug, please be sure to include the following:

  • The outcome of the react-native-modal-datetime-picker swap described above
  • A descriptive title
  • An isolated way to reproduce the behavior (example: GitHub repository with code isolated to the issue that anyone can clone to observe the problem)
  • What version of react-native-modal-datetime-picker you're using, and the platform(s) you're running it on (iOS, Android, device)
  • What packages or other dependencies you're using
  • The behavior you expect to see, and the actual behavior

@suhabaobaid
Copy link

+1

@suhabaobaid
Copy link

it seems It has a problem with time mode, date mode seems to work just fine for me

@mmazzarolo
Copy link
Owner

Hey everyone, could you please read and fill the issue template?
Thanks

@MihaiSandor
Copy link
Author

Yes

@mmazzarolo
Copy link
Owner

When reporting a bug, please be sure to include the following:

  • The outcome of the react-native-modal-datetime-picker swap described above
  • A descriptive title
  • An isolated way to reproduce the behavior (example: GitHub repository with code isolated to the issue that anyone can clone to observe the problem)
  • What version of react-native-modal-datetime-picker you're using, and the platform(s) you're running it on (iOS, Android, device)
  • What packages or other dependencies you're using
  • The behavior you expect to see, and the actual behavior

@mmazzarolo mmazzarolo changed the title Wrong date. Wrong time. Apr 6, 2018
@julestruong
Copy link

julestruong commented Apr 10, 2018

Hello

Just adding thoughts, it happens to bug only on device, not on simulator. Also only on IOS.
This also appears to happen randomly, roughly one in two

@MihaiSandor have u found a solution ? this case is really tricky

@mmazzarolo
Copy link
Owner

Thanks for the feedback @julestruong
May it be related to #149? From my testing it was working nicely though...
Also, did you already try the native ios time-picker?

@julestruong
Copy link

Hello @mmazzarolo no its not.

It seems to be related to facebook/react-native#8169.
So you might not be able to fix this on your library :(

@mmazzarolo
Copy link
Owner

Oh, yeah, the good old issue 8169 😄
Take a look at this discussion, #115, they seems to have find a way to fix it with a custom picker component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants