1.3.0 release #151

riccardoporreca · 2019-10-29T11:56:26Z

Changes

The app now uses custom collapsible panels, removing the dependency on shinydashboardPlus (Remove shinydashboardPlus dependency #113).
The Dockerfile for the deployed app was improved, and is now based on R 3.5.3 (Upgrade to R 3.5.3 #91, No PNG images with new TeXLive: Use version-stable TinyTeX #152).
The total retirement fund text in the app was improved (Review "Total retirement fund ..." element and spacing #114).
The PDF report now uses A4 as pages size (A4 PDF report #131).
The increment of interest rates in the app is now aligned to 0.1% (Align step in Interest Rate in P2 #142).
The iframe-resizer version was upgraded to 4.2.1 (Update to iFrame Resizer 4.2.1 #144).

Maintenance

Instructions and manifests for the GKE deployment are now included in the gke directory (Include GKE instructions and manifests #141).
GitFlow and release details are now included in the git-flow directory (Updates after Mirai website integration #143).
The README was updated based on the new website integration of the deployed app (Updates after Mirai website integration #143).

* To be documented, standalone example exists under man-roxygen. * Removed shinydashboardPlus dependency, tooltips to be reviewd after removal. * Consolidated all JS in UI's head.

* Produces the same tooltips as with the former shinydashboardPlus.

* Support no title in collapsible panels via min-height, included in example.

Merge branch 'develop' of https://github.com/miraisolutions/SmaRP into feature/113-rm-shinydashboardPlus # Conflicts: # NEWS.md

* Reviewed minimal set of system dependencies. * Switch to TinyTeX instead of the full bulk of TeX Live. * Use newer pandoc (aligned to rocker/rstudio), recommended for rmardkown. * Install SmaRP and its dependencies via remotes::install_local(). * Keep explicit preliminary installation of major, fixed R dependencies.

* Not used and causing extra LaTeX packages to be installed at run-time, slowing down the first report generated from a container.

* Formerly needed only for shinyWidgets::useShinydashboardPlus().

…m/miraisolutions/SmaRP into feature/113-rm-shinydashboardPlus

* Also include a TinyTeX re-installation wrapper.

See yihui/yihui.org@1b7eefd

* Script only used in the example, not run. * Revert to simple name for the local testing image.

…o feature/91-r-3.5.3

* Also ignore docker scripts directory.

* Initial draft adapted from the private miscellaneous repo.

Review Dockerfile with upgrade to R 3.5.3

Include GKE instructions and manifests

* Also aligned italic text for semantic versioning components.

Issue #149 created to consider that.

Not supporterd in GFM.

…ration-updates Website integration updates

…r-4.2.1 Upgrade iframe-resizer to version 4.2.1

* closes #91 * closes #113 * closes #114 * closes #131 * closes #141 * closes #142 * closes #143 * closes #144

riccardoporreca · 2019-11-01T09:51:19Z

There is an issue when running SmaRP from the Docker container as the usual test in the release process: The PNG images of the Swiss pension system and Tax benefits in the PDF report are not shown. Issue #152 opened to address it and to be included in the release branch once fixed.

* Fixes #152.

…elease. * See comments in #152.

…e-tinytex Version-stable TinyTeX

riccardoporreca · 2019-11-05T14:02:26Z

Check running SmaRP from the Docker container after the inclusion of #152 via

git checkout release/v1.3.0
docker build --pull -f Dockerfile -t mirai/smarp:test-1.3.0 .
docker run --rm -p 80:80 mirai/smarp:test-1.3.0

The app behaves correctly and the PDF report is correctly produced. @gabrielfoix, feel free to approve after any further checks you may want to do.

gabrielfoix

FIne with fix. Go ahead.

riccardoporreca and others added 30 commits April 3, 2019 08:30

Initial replacement of boxPlus() with custom SmaRPanel (#113).

419b158

* To be documented, standalone example exists under man-roxygen. * Removed shinydashboardPlus dependency, tooltips to be reviewd after removal. * Consolidated all JS in UI's head.

Cleanup ad-hoc workaround to AdminLTE.min.css (#113, #69).

6ba3ae2

Use container = "body" tooltip option #113.

9a791a1

* Produces the same tooltips as with the former shinydashboardPlus.

Purge shinydashboardPlus from Dockerfile (#113).

a98c47a

Refine and document SmaRPanel #113.

2da4c85

* Support no title in collapsible panels via min-height, included in example.

Updated NEWS for #113.

48937f9

Resolved PR #116 merge conflicts.

036bb65

Merge branch 'develop' of https://github.com/miraisolutions/SmaRP into feature/113-rm-shinydashboardPlus # Conflicts: # NEWS.md

Merge branch 'develop' into feature/113-rm-shinydashboardPlus

aac99fb

Remove kableExtra dependency (#91).

092dee9

* Not used and causing extra LaTeX packages to be installed at run-time, slowing down the first report generated from a container.

Remove legacy shinyWidgets dependency (#113).

29de1c8

* Formerly needed only for shinyWidgets::useShinydashboardPlus().

Merge branch 'feature/113-rm-shinydashboardPlus' of https://github.co…

1791b36

…m/miraisolutions/SmaRP into feature/113-rm-shinydashboardPlus

Merge branch 'develop' into feature/113-rm-shinydashboardPlus

fab18ba

Fix new pillar naming, not merged correctly from develop.

c128961

Minor cosmetic improvements (#91)

694d694

Pandoc and TinyTeX installation as stand-alone scripts (#91).

b5643d6

* Also include a TinyTeX re-installation wrapper.

updated SmaRP version in NEWS.md and DESCRIPTION

ee9e438

No need to remove the platform identifier.

617f9f6

See yihui/yihui.org@1b7eefd

review with minimal edits

80eb661

Elaborate more on TinyTeX reinstallation.

e1cee46

* Script only used in the example, not run. * Revert to simple name for the local testing image.

Merge branch 'develop' of https://github.com/miraisolutions/SmaRP int…

9c7c416

…o feature/91-r-3.5.3

Fix example image tag as agreed in PR #140.

dbf0b72

* Also ignore docker scripts directory.

Updated NEWS for #91.

39cccbc

GKE instruction and YAML manifests.

2851496

* Initial draft adapted from the private miscellaneous repo.

Build-ignore gke directory.

7092f75

Explicit comment about WebSockets and timout.

ba7d797

Merge pull request #140 from miraisolutions/feature/91-r-3.5.3

25eafa1

Review Dockerfile with upgrade to R 3.5.3

update NEWS

43a09b8

Merge branch 'develop' into feature/gke-instructions

f845712

Merge pull request #141 from miraisolutions/feature/gke-instructions

5d5b286

Include GKE instructions and manifests

riccardoporreca and others added 13 commits October 11, 2019 09:57

Mention avoiding specific bugfix branches (#143).

1f9eb21

* Also aligned italic text for semantic versioning components.

Minor grammar fix.

f4a26f1

Removed comment about running SmaRP Docker image locally.

466aea0

Issue #149 created to consider that.

Use remotes for install_github().

8601936

Rephrasing and refining feature branch bullet.

0f2e728

No custom anchor for release section.

015f4ca

Not supporterd in GFM.

Re-structure references.

ba5b9ac

fixed typo

e4189d8

Merge pull request #148 from miraisolutions/feature/143-website-integ…

a5aea20

…ration-updates Website integration updates

Upgrade to iFrame Resizer 4.2.1 (closes #144).

0ddb1e1

News updated for #144.

7462625

Merge pull request #150 from miraisolutions/feature/144-iframe-resize…

3a0b702

…r-4.2.1 Upgrade iframe-resizer to version 4.2.1

1.3.0 release preps

9574051

* closes #91 * closes #113 * closes #114 * closes #131 * closes #141 * closes #142 * closes #143 * closes #144

riccardoporreca requested a review from gabrielfoix October 29, 2019 11:56

riccardoporreca added this to the Autumn release 1.3.0 milestone Oct 29, 2019

riccardoporreca mentioned this pull request Nov 1, 2019

No PNG images with new TeXLive: Use version-stable TinyTeX #152

Closed

riccardoporreca added 3 commits November 1, 2019 13:02

Use version-stable TinyTeX for the deployed app.

0a69df4

* Fixes #152.

Use .dockerignore to limit the build context and improve caching (#152).

b55f558

Include #152 in NEWS.md

85c297f

riccardoporreca mentioned this pull request Nov 1, 2019

Version-stable TinyTeX #153

Merged

riccardoporreca and others added 2 commits November 5, 2019 10:40

Revises version-stable TinyTeX, aligned with Debian stretch TeXLive r…

4ef96c6

…elease. * See comments in #152.

Merge pull request #153 from miraisolutions/feature/152-version-stabl…

75d7f00

…e-tinytex Version-stable TinyTeX

gabrielfoix approved these changes Nov 5, 2019

View reviewed changes

riccardoporreca self-assigned this Nov 5, 2019

riccardoporreca merged commit d5033aa into master Nov 5, 2019

riccardoporreca deleted the release/v1.3.0 branch November 5, 2019 16:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1.3.0 release #151

1.3.0 release #151

riccardoporreca commented Oct 29, 2019 •

edited

Loading

riccardoporreca commented Nov 1, 2019 •

edited

Loading

riccardoporreca commented Nov 5, 2019 •

edited

Loading

gabrielfoix left a comment

1.3.0 release #151

1.3.0 release #151

Conversation

riccardoporreca commented Oct 29, 2019 • edited Loading

Changes

Maintenance

riccardoporreca commented Nov 1, 2019 • edited Loading

riccardoporreca commented Nov 5, 2019 • edited Loading

gabrielfoix left a comment

Choose a reason for hiding this comment

riccardoporreca commented Oct 29, 2019 •

edited

Loading

riccardoporreca commented Nov 1, 2019 •

edited

Loading

riccardoporreca commented Nov 5, 2019 •

edited

Loading