Review Dockerfile with upgrade to R 3.5.3 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reviewed minimal set of system dependencies. * Switch to TinyTeX instead of the full bulk of TeX Live. * Use newer pandoc (aligned to rocker/rstudio), recommended for rmardkown. * Install SmaRP and its dependencies via remotes::install_local(). * Keep explicit preliminary installation of major, fixed R dependencies.
* Not used and causing extra LaTeX packages to be installed at run-time, slowing down the first report generated from a container.
* Also include a TinyTeX re-installation wrapper.
RolandASc
approved these changes
Jul 4, 2019
riccardoporreca
commented
Jul 4, 2019
riccardoporreca
commented
Jul 4, 2019
* Script only used in the example, not run. * Revert to simple name for the local testing image.
|
@RolandASc, please re-review my last commit e1cee46 in view of my comments above. |
RolandASc
approved these changes
Jul 5, 2019
…o feature/91-r-3.5.3
* Also ignore docker scripts directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #91