Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website integration updates #148

Merged
merged 17 commits into from
Oct 22, 2019
Merged

Website integration updates #148

merged 17 commits into from
Oct 22, 2019

Conversation

riccardoporreca
Copy link
Member

See #143

nfarabullini
nfarabullini suggested changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@nfarabullini nfarabullini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments to look at, mostly personal phrasing preferences

git-flow/README.md Outdated Show resolved Hide resolved
git-flow/README.md Outdated Show resolved Hide resolved
git-flow/README.md Outdated Show resolved Hide resolved
git-flow/README.md Outdated Show resolved Hide resolved
git-flow/README.md Show resolved Hide resolved
git-flow/README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@riccardoporreca @nfarabullini
Apply suggestions from code review
e1c8c9f 
Co-Authored-By: nfarabullini <41536517+nfarabullini@users.noreply.github.com>
gabrielfoix
gabrielfoix approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@gabrielfoix gabrielfoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@riccardoporreca
Copy link
Member Author

@RolandASc, I have integrated the refinements we discussed.

RolandASc
RolandASc approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@RolandASc RolandASc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielfoix gabrielfoix merged commit a5aea20 into develop Oct 22, 2019
@riccardoporreca riccardoporreca deleted the feature/143-website-integration-updates branch November 5, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfarabullini nfarabullini nfarabullini requested changes

@gabrielfoix gabrielfoix gabrielfoix approved these changes

@RolandASc RolandASc RolandASc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@riccardoporreca @RolandASc @gabrielfoix @nfarabullini