Updating my fork #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial commit Initial commit * Changes for new API version 2017-12-01-preview Changes for new API version 2017-12-01-preview * ReadMe changes ReadMe changes * Swagger changes for ACI Swagger changes for ACI * More changes on ACI swagger spec More changes on ACI swagger spec * Remove secrets from the response Remove secrets from the response
…ference refining) (#2192) * Refine naming and use unified faceUserData as request parameter * 1)Refine naming 2)Use unified request parameter 3) Extract struct NameAndUserDataContract to be inheriated and as parameter * Remove FaceListMetaData, return FaceList in both get/list facelist/facelists * Remove AddPersistedFaceResult and use PersistedFace instead * Remove CreatePersonResult and use Person instead * Nit alphabetic case things * Nit add/fix comments * Refine overload method naming, fix nullable guids and fix identify comments and number limits * Refine naming for overloaded methods, refine comments * Rename Person->PersonGroupPerson in FaceAPI * Adjust parameter order for VerifyFaceToPerson to be compatible with origin SDK * Add enum for AccessoryType and HairColorType
* Add build tags for Go SDK. A lot of new config files are missing build tags for the Go SDK. * Remove dupes from bad merge. * Reworked directory structure for LUIS packages. * Fix bad path to swagger.
…tions (#2210) * updating keyvault RM swagger to include missing definitions and examples * fixing updated paths in readme.md * moving attributes definition into secrets.json * referencing Resource definition from keyvault.json in secrets.json * updates addressing PR feedback * fixing linting issues introduced with updates * moving listOperations method to providers.json as it's not a vault operation * adding providers.json to readme.md * fixing syntax error in keyvault.json * fixing typos in property descriptions * fixing parameter name in example checkVaultNameAvailability.json * updating descriptions and examples based on PR feedback * adding 201 response to updateSecret.json example
…d by Azure Storage and Azure EventHub services. (#2147) * Swagger for Azure Event Grid. * Added x-ms-examples for all the operations. * Removed TopicTypes_list.json as the casing doesn't match what's referenced in the Swagger. * Re-adding TopicTypes_List.json with the correct casing. * Fixed a set of validation errors in the examples. * Added x-ms-examples for the 2017-09-15-preview API version of Azure Event Grid. * Fixed examples to avoid the double forward slash in the scope parameter. * Support for patching an EventGrid topic (to update tags). * Updated description in the response of topic patch operation. * Swagger for the Event Grid data plane. * Fixed the casing of readOnly field, added x-ms-example. * Fixed a missing parameter in the example file. * Added readme.md to capture the AutoRest configuration for EventGrid data plane. * Swagger definitions for the schemas of the Event Grid events published by Azure Storage and Azure EventHub services. * Resolved the validation errors. * Use the new convention ("stable") in the directory structure.
* Invite User functionality * Fix Issue with Example
* Add live validation * Address PR comments
…2223) * Added connection monitor apis to network watcher swagger + examples * Fixed examples for connection monitor * Fixed linter issues. Wdded ref to examples * Deleted ref to examples
* Fixes * Fixed oauth property * Missed previous changes * Fix semantic errors
This swagger is not year ready for consumption by languages other than C# so I have removed the codegen section for Go.
* Added new receivers to action group document. * fixed few comments. * Corrected the file syntactically using openapi-linter * Add required patch operation for which it is flagging this documentation * Fixed some liter format validation issues, added patch example * Fixed couple for validation errors * Fixed new validation error for runbook receiver * fixed the description field for ITSM Ticket configuration field. * Added new receivers to action group document. * fixed few comments. * Corrected the file syntactically using openapi-linter * Add required patch operation for which it is flagging this documentation * Fixed some liter format validation issues, added patch example * Fixed couple for validation errors * Fixed new validation error for runbook receiver * fixed the description field for ITSM Ticket configuration field. * Added example file for patch operation to new directory called stable.
Set C# namespace to Microsoft.Azure.Management.ProvisioningServices to keep in line with the actual spec instead of reusing Microsoft.Azure.Management.IotHub which is causing conflicts.
* Update notification contract to return resourceId of email * Add missing examples for operations
* [Azure Search] Adding PATCH Services to Swagger Support for PATCH was added to the Azure Search RP. This change adds it to the Swagger spec so it will be documented and included in generated SDK code. * [Azure Search] Adding x-ms-examples to Management plane Swagger spec * [Azure Search] Removing required properties to resolve PATCH linter errors * [Azure Search] Removing x-ms-long-running-operation from PATCH It doesn't seem to be supported by the .NET ClientRuntime for resource-based polling. * [Azure Search] Fixing a few Swagger linter warnings * [Azure Search] Adding Operations API to management plane Swagger * [Azure Search] Fixing validation error in Management API example * [Azure Search] Fixing broken delete query key example * [Azure Search] Clarifying in spec that location and sku are required on Create
* [Network-2017-11-01] Pull latest from current (#2039) * Video Swagger API: update example response json to remove special invalid special characters (#2015) * Add Video Search API Swagger * Video Swagger API: update example response json to remove special invalid special characters * take changes from azure-rest-spec-pr, make Microsoft.Subscription tenant level rp (#1984) * Fix bad merge. (#2022) * Add list apis for sql backup LTR policies & vaults (#2006) * Add list LTR vaults & policies * Added pageable * Change output folder for Search SDKs (#2023) * update output folders in readmes * rename with bing in name * App Model for Tumbling window trigger (#2028) * App model for tumbling window trigger * Addressed CR comments * Renamed retry to count in RetryPolicy * swagger definition for 26 RFI connectors (#2016) * Updated OMS data plane C# namespace & output-folder (#2021) * Update Azure Batch enum to use "values" - also some documentation updates (#2008) * Enum fixes * Improve DataDisks documentation * Update NATPool port range documentation * [Compute] Update Sku APIs (#2034) * Initial commit of 2017-12-01 compute.json * Changes for new API version 2017-12-01 compute.json * Add Compute SKU APIs * Add swagger spec for spell check API (#1997) * Add swagger spec for spell check API * Add Examples to spec * Remove redundant forward slash in path. Specify array from body parameters. * Fix oav errors * Remove x-Bing_Apis-SDK * Change spec to reflect what objects we want to expose in the response. * Fix operationId name to avoid conflict with "SpellCheck" schema. * Add X-BingApis-SDK back. * Remove Unintentional change Packages.json change here was unintentionally added to this review * Add 2017-11-01 folder in microsoft.network (#2019) * Video Swagger API: update example response json to remove special invalid special characters (#2015) * Add Video Search API Swagger * Video Swagger API: update example response json to remove special invalid special characters * take changes from azure-rest-spec-pr, make Microsoft.Subscription tenant level rp (#1984) * Fix bad merge. (#2022) * Add 2017-11-01 folder in microsoft.network * Add Ip Tags into Swagger (#2145) * add iptags for publicip in 2017-11-01 * read me changes for 2017-11-01 * Add Python conf for Network 2017-11-01 * Complete Python conf for 2017-11-01 * Updated LB InboundNatPool API (#2150) * Revert "[Network-2017-11-01] Pull latest from current (#2039)" This reverts commit a0257f9. * Moving to stable folder to account for refactoring changes in dec 2017
* Fix or suppress spec violations Fix R2016 by making PATCH body properties optional. Suppress the remaining 4 violations that are confirmed as false positives. * Try removing 2nd top-level heading, which _may_ have been causing a linter warning. * Fix extra indention which prevented linter from running.
* Add event grid schema for ACR * Update readme file * Prefix class name with ContainerRegistry
…2231) * fix service map swagger validation errors * remove the extra comma in examples/Machines/MachineGroups/SMMachinesListMachineGroupMembershipGet.json * remove extra comma for client groups operation examples * ARM operation examples: replace parameter workspaceId with workspaceName * add required parameter machineGroupName for example SMMachineGroupsUpdatePut.json * fix resource id and types * fix more example validation errors * fix validation errors
…application/json for /policies/{id} for GET/PUT operations (#2495)
* byRequest path fixed, schema reference fixed
* /reports/by... routes fixed
* Declared content types supported by API in addition to application/json
* Fixed get to produce mime types
* Redeclared consumed and produced MIME types supported in addition to application/json for /policies/{id} for GET/PUT operations
* Corrected API versions * Move to correct folder * Fix version * Correct swagger version * Fixed example
Tag_ operations have all been moved to apimtags.json file. Removing them from apimproducts.json Apis_ListByTags have been moved to apimapis.json, removing the file apimapisbytags.json
… had incorrect format for the date values. (#2499) * Refactoring Pricesheet response spec to fix model names and references. * Updating examples to correctly reflect the response model * Fixing examples for updated pricesheet model response. * Providing nextLink name and removing x-ms-pageable for budget PUT operation. * Fixing nextLink definition in response schema. * Updating $filter parameter sample values in examples. Earlier version had incorrect format for the date values.
* AzureStack * Formatted and Fixed some casings
…ok areas (#2360) * Make 'properties' not required for PATCH on AutomationAccount_Update * Make 'name' not required for PATCH on 'Webhook_Update' * Add x-ms-azure-resource=true to Webhook definition
Make possible to provide more detailed information about the storage devices attached to a given hana instance.
The statusMessage can be a string or a JSON object, so model it as a wildcard type.
* appgw examples #2 * ssl options example * waf examples
* Microsoft.Automation linkedWorkspace operations * Microsoft.Automation LinkedWorkspace operations use $ref ResourceGroupNameParameter
* Adding new API version 2018-01-10 fixing swagger voilations * Updating readme file for new API:2018-01-10 * Updating api examples * Reverting alphabetical ordering of operations and definitions for easier review. * Taking review comments and introducing missing polymorphic fields for NetworkMappingFabricSpecificSettings * Alphabetically sorting definitions and API paths.
* Add new features 1. SecureOutput and BatchCount 2. Filter Activity 3. LInked Service Parameters 4. FilterActivity * Fix indentations * Fix review comments
#2515) This seems like the path of least resistance to getting AutoRest (and the scripts in azure-sdk-for-net that invoke it) to properly handle a data plane SDK with two specs. Also, we're planning to split our data plane into separate libraries, so this is a sensible first step.
#2435) * Adding 2018-01-01 version for metrics API * Fix extra comma at the end of line * Fix PR comments 1 * Fixing top/orderby names, Please be reminded, there is no code change, it's just a typo of the names. * Fix the sample to reflect the parameter * Fix meta data sample as well.
…2508) * Updated examples for network watcher * Updated api version in network watcher swagger and examples * Fixed Linter errors * Fixed Linter errors: iteration 2
* adding purge protection vault property * Expanding the description of the soft delete and purge protection properties, respectively. Updating examples with and without soft delete and purge protection flags. * relocating the newly introduced property to the end of the schema
* Added ApiVersionSets * Fixes based on CR * Refactored JSON Schemas for payloads * fixed names and reference * Fixed reference to schema for ApiVersionSets * Fixed ApiVersionSetCreate example
* fix the hardcoding of api version for classicadmin in sdk * fix 2017 version preview file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger