Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GH token from Travis file #2217

Merged
merged 1 commit into from
Jan 5, 2018
Merged

Remove GH token from Travis file #2217

merged 1 commit into from
Jan 5, 2018

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented Jan 5, 2018

We don't want to push this token to private when syncing

@salameer @veronicagg @marstr

@lmazuel lmazuel self-assigned this Jan 5, 2018
Copy link
Contributor

@veronicagg veronicagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with the change, I see that you added the token in Travis settings already. How does the env var token get consumed?

@lmazuel
Copy link
Member Author

lmazuel commented Jan 5, 2018

@veronicagg Travis allows two way to passe secure env variables:

  • global.secure section in Travis.yaml
  • Env variables in settings

This is the same thing, so removing the global.secure section means that now Travis will search for GH_TOKEN in the settings (and it will find it). So no change at all of behavior, we just move the token from one spot to another.

From the doc:

If you define a variable with the same name in .travis.yml and in the Repository Settings, the one in .travis.yml takes precedence.

https://docs.travis-ci.com/user/environment-variables/#Defining-encrypted-variables-in-.travis.yml
https://docs.travis-ci.com/user/environment-variables/#Defining-Variables-in-Repository-Settings

@lmazuel lmazuel merged commit 5ed2219 into Azure:master Jan 5, 2018
@lmazuel lmazuel deleted the remove_ghtoken branch January 5, 2018 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants