Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

take changes from azure-rest-spec-pr, make tenant level rp #1984

Merged
merged 1 commit into from
Nov 16, 2017
Merged

take changes from azure-rest-spec-pr, make tenant level rp #1984

merged 1 commit into from
Nov 16, 2017

Conversation

mjfrb
Copy link
Contributor

@mjfrb mjfrb commented Nov 8, 2017 •
edited by azuresdkci
Loading

Microsoft.Subscription still isn't released yet. This PR brings forwards changes from azure-rest-api-specs-pr. This swagger focuses on the customer ask simplifying the surface to just create, get and list. Microsoft.Subscription will not rely on groupsrp for this release.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/resources/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 71
After the PR: Warning(s): 0 Error(s): 71

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

mcardosos
mcardosos approved these changes Nov 8, 2017
View reviewed changes
Copy link
Contributor

@mcardosos mcardosos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already approved on pr repo by @olydis
Only difference is List operation is now marked as pageable, which LGTM

@mcardosos
Copy link
Contributor

@mjfrb When will this be deployed? I will merge after that :)

@mjfrb
Copy link
Contributor Author

mjfrb commented Nov 8, 2017

We will deploy into production tomorrow or Friday morning at the latest.

@mcardosos
Copy link
Contributor

@mjfrb is it deployed?

@mcardosos
Copy link
Contributor

@mjfrb Ping

@mjfrb
Copy link
Contributor Author

mjfrb commented Nov 16, 2017

Sorry for the delay, we've deployed. I'd like to get this wrapped up.

@mcardosos
Copy link
Contributor

Awesome! Thanks for the update :D
Merging...

@mcardosos mcardosos merged commit 1468e76 into Azure:current Nov 16, 2017
@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI AutorestCI mentioned this pull request Nov 16, 2017
Closed
@AutorestCI
Copy link

Build Status Azure/azure-sdk-for-python#1631

@AutorestCI AutorestCI mentioned this pull request Nov 16, 2017
Closed
@AutorestCI
Copy link

Build Status Azure/azure-sdk-for-ruby#1139

sergey-shandar pushed a commit that referenced this pull request Nov 22, 2017
@murilogiacometti @sergey-shandar
[Network-2017-11-01] Pull latest from current (#2039)
a0257f9 
* Video Swagger API: update example response json to remove special invalid special characters (#2015)

* Add Video Search API Swagger

* Video Swagger API: update example response json to remove special invalid special characters

* take changes from azure-rest-spec-pr, make Microsoft.Subscription tenant level rp (#1984)

* Fix bad merge. (#2022)

* Add list apis for sql backup LTR policies & vaults (#2006)

* Add list LTR vaults & policies

* Added pageable

* Change output folder for Search SDKs (#2023)

* update output folders in readmes

* rename with bing in name

* App Model for Tumbling window trigger (#2028)

* App model for tumbling window trigger

* Addressed CR comments

* Renamed retry to count in RetryPolicy

* swagger definition for 26 RFI connectors (#2016)

* Updated OMS data plane C# namespace & output-folder (#2021)

* Update Azure Batch enum to use "values" - also some documentation updates (#2008)

* Enum fixes

* Improve DataDisks documentation

* Update NATPool port range documentation

* [Compute] Update Sku APIs (#2034)

* Initial commit of 2017-12-01 compute.json

* Changes for new API version 2017-12-01 compute.json

* Add Compute SKU APIs

* Add swagger spec for spell check API (#1997)

* Add swagger spec for spell check API

* Add Examples to spec

* Remove redundant forward slash in path. Specify array from body parameters.

* Fix oav errors

* Remove x-Bing_Apis-SDK

* Change spec to reflect what objects we want to expose in the response.

* Fix operationId name to avoid conflict with "SpellCheck" schema.

* Add X-BingApis-SDK back.

* Remove Unintentional change 

Packages.json change here was unintentionally added to this review
sergey-shandar pushed a commit that referenced this pull request Nov 27, 2017
@chandrasekarsrinivasan @sergey-shandar
Add 2017-11-01 folder in microsoft.network (#2019)
1fc1bf2 
* Video Swagger API: update example response json to remove special invalid special characters (#2015)

* Add Video Search API Swagger

* Video Swagger API: update example response json to remove special invalid special characters

* take changes from azure-rest-spec-pr, make Microsoft.Subscription tenant level rp (#1984)

* Fix bad merge. (#2022)

* Add 2017-11-01 folder in microsoft.network
sergey-shandar pushed a commit that referenced this pull request Jan 11, 2018
@chandrasekarsrinivasan @sergey-shandar
Merge Network 2017-11-01 to master (#2203)
b0e4eae 
* [Network-2017-11-01] Pull latest from current (#2039)

* Video Swagger API: update example response json to remove special invalid special characters (#2015)

* Add Video Search API Swagger

* Video Swagger API: update example response json to remove special invalid special characters

* take changes from azure-rest-spec-pr, make Microsoft.Subscription tenant level rp (#1984)

* Fix bad merge. (#2022)

* Add list apis for sql backup LTR policies & vaults (#2006)

* Add list LTR vaults & policies

* Added pageable

* Change output folder for Search SDKs (#2023)

* update output folders in readmes

* rename with bing in name

* App Model for Tumbling window trigger (#2028)

* App model for tumbling window trigger

* Addressed CR comments

* Renamed retry to count in RetryPolicy

* swagger definition for 26 RFI connectors (#2016)

* Updated OMS data plane C# namespace & output-folder (#2021)

* Update Azure Batch enum to use "values" - also some documentation updates (#2008)

* Enum fixes

* Improve DataDisks documentation

* Update NATPool port range documentation

* [Compute] Update Sku APIs (#2034)

* Initial commit of 2017-12-01 compute.json

* Changes for new API version 2017-12-01 compute.json

* Add Compute SKU APIs

* Add swagger spec for spell check API (#1997)

* Add swagger spec for spell check API

* Add Examples to spec

* Remove redundant forward slash in path. Specify array from body parameters.

* Fix oav errors

* Remove x-Bing_Apis-SDK

* Change spec to reflect what objects we want to expose in the response.

* Fix operationId name to avoid conflict with "SpellCheck" schema.

* Add X-BingApis-SDK back.

* Remove Unintentional change 

Packages.json change here was unintentionally added to this review

* Add 2017-11-01 folder in microsoft.network (#2019)

* Video Swagger API: update example response json to remove special invalid special characters (#2015)

* Add Video Search API Swagger

* Video Swagger API: update example response json to remove special invalid special characters

* take changes from azure-rest-spec-pr, make Microsoft.Subscription tenant level rp (#1984)

* Fix bad merge. (#2022)

* Add 2017-11-01 folder in microsoft.network

* Add Ip Tags into Swagger (#2145)

* add iptags for publicip in 2017-11-01

* read me changes for 2017-11-01

* Add Python conf for Network 2017-11-01

* Complete Python conf for 2017-11-01

* Updated LB InboundNatPool API (#2150)

* Revert "[Network-2017-11-01] Pull latest from current (#2039)"

This reverts commit a0257f9.

* Moving to stable folder to account for refactoring changes in dec 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcardosos mcardosos mcardosos approved these changes

Assignees

@mcardosos mcardosos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjfrb @azuresdkciprbot @mcardosos @AutorestCI