Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: WiX Toolset #89819

Closed
wants to merge 7 commits into from
Closed

Conversation

FernandoNunes
Copy link
Contributor

@FernandoNunes FernandoNunes commented Nov 27, 2022

  • Have you signed the Contributor License Agreement?
  • [ x ] Have you checked that there aren't other open pull requests for the same manifest update/change?
  • [ x ] Have you validated your manifest locally with winget validate --manifest <path>?
  • [ x ] Have you tested your manifest locally with winget install --manifest <path>?
  • [ x ] Does your manifest conform to the 1.2 schema?

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Nov 27, 2022
@ghost ghost assigned FernandoNunes Nov 27, 2022
@ghost
Copy link

ghost commented Nov 27, 2022

Hello @FernandoNunes,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 27, 2022
@ghost ghost assigned stephengillie and ryfu-msft Nov 27, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Nov 27, 2022
@ghost ghost removed the Needs-Author-Feedback This needs a response from the author. label Nov 27, 2022
@FernandoNunes FernandoNunes reopened this Nov 27, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Nov 27, 2022
@ghost ghost assigned FernandoNunes Nov 27, 2022
@ghost
Copy link

ghost commented Nov 27, 2022

Hello @FernandoNunes,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 27, 2022
@ghost ghost assigned stephengillie and ryfu-msft Nov 27, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Nov 28, 2022
@ghost ghost assigned FernandoNunes Nov 28, 2022
@ghost
Copy link

ghost commented Nov 28, 2022

Hello @FernandoNunes,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 28, 2022
@ghost ghost assigned stephengillie and ryfu-msft Nov 28, 2022
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost removed the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Nov 28, 2022
@ghost ghost removed the Needs-Author-Feedback This needs a response from the author. label Nov 28, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Nov 28, 2022
@ghost ghost assigned FernandoNunes Nov 28, 2022
@ghost
Copy link

ghost commented Nov 28, 2022

Hello @FernandoNunes,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Nov 28, 2022
@ghost ghost assigned stephengillie and ryfu-msft Nov 28, 2022
@FernandoNunes
Copy link
Contributor Author

@stephengillie / @ryfu-msft / @mtodd I can't seem to get this installer to work on the Installer-Validation step, but all the various manifests configs I've tried they all "Work on my machine ™".
Are you guys able to help ?

Best regards,
Fernando Nunes

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 28, 2022
@Trenly
Copy link
Contributor

Trenly commented Nov 28, 2022

This has a dependency, which is why it is failing.

Note: WiX Toolset requires the .NET Framework 3.5 Windows feature to be enabled.

@msftbot dependencies

Close with reason: See above;

@ghost ghost added Needs-Author-Feedback This needs a response from the author. Dependencies Blocking-Issue Manifest validation is blocked by a known issue. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Nov 28, 2022
@ghost ghost closed this Nov 28, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Dependencies Needs-Author-Feedback This needs a response from the author. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants