-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WiXToolset 3.11.2 #895
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
This submission has moved to manual review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this, I was about to, but figured I should check the pull requests first.
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
This submission has moved to manual review. |
chausner The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request. |
when trying to install it showed an error, and shows UI. |
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
chausner The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request. |
This PR is a bit old 😄 I'm not sure if we need support for dependencies and/or standalone .exe applications for this to work. In either case, the manifest needs to be updated to the current schema. |
I would say this is a very special case since the external dependency (.NET Framework 3.5) is not a regular program/package but has to be enabled as a Windows feature. |
@chausner we added support for Windows Features as a possible type of dependency in the v1.0 schema. We're still looking into the implications of making Windows Features as dependencies since it may require a reboot. I've seen one suggestion where they are created as "packages" so the package level dependency could be used. More analysis is required to understand edge cases and the best UX. |
Clearing assignees until unblocked. |
I'm going to close this PR because it is so old and doesn't conform to any of the current schemas. Additionally, the base branch is (at the time of writing) 84,000 commits behind Close with reason: See above; |
Note: WiX Toolset requires the .NET Framework 3.5 Windows feature to be enabled.
Microsoft Reviewers: Open in CodeFlow