Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WiXToolset 3.11.2 #895

Closed
wants to merge 5 commits into from
Closed

Conversation

chausner
Copy link
Contributor

@chausner chausner commented May 23, 2020

Note: WiX Toolset requires the .NET Framework 3.5 Windows feature to be enabled.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 23, 2020
@ghost ghost assigned RDMacLachlan May 23, 2020
@ghost
Copy link

ghost commented May 23, 2020

This submission has moved to manual review.

Copy link
Contributor

@TheQuazman TheQuazman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, I was about to, but figured I should check the pull requests first.

manifests/WiXToolset/WiXToolset/3.11.2.yaml Outdated Show resolved Hide resolved
manifests/WiXToolset/WiXToolset/3.11.2.yaml Outdated Show resolved Hide resolved
manifests/WiXToolset/WiXToolset/3.11.2.yaml Outdated Show resolved Hide resolved
@wingetbot wingetbot removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 25, 2020
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label May 25, 2020
@ghost ghost assigned samiranshah-zz May 25, 2020
@ghost
Copy link

ghost commented May 25, 2020

This submission has moved to manual review.

@KevinLaMS KevinLaMS added the Validation-Installation-Error Error installing application label May 25, 2020
@ghost
Copy link

ghost commented May 25, 2020

chausner The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@ghost ghost added Needs: author feedback and removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels May 25, 2020
@KevinLaMS
Copy link
Contributor

when trying to install it showed an error, and shows UI.

@ghost ghost added the No-Recent-Activity No activity has occurred on this work item for seven days. label Jun 1, 2020
@ghost
Copy link

ghost commented Jun 1, 2020

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost removed the Needs: author feedback label Jun 1, 2020
@KevinLaMS KevinLaMS added the Blocking-Issue Manifest validation is blocked by a known issue. label Jul 20, 2020
@KevinLaMS
Copy link
Contributor

image

Looks like there is a dependency that is missing.

@ghost
Copy link

ghost commented Jul 20, 2020

chausner The package manager bot determined there was an issue with installing the application correctly. Please check the application installs correctly. Once repaired, please push an update to your pull request.

@KevinLaMS
Copy link
Contributor

microsoft/winget-cli#182

@denelon
Copy link
Contributor

denelon commented May 4, 2021

This PR is a bit old 😄

I'm not sure if we need support for dependencies and/or standalone .exe applications for this to work.

In either case, the manifest needs to be updated to the current schema.

@chausner
Copy link
Contributor Author

chausner commented May 4, 2021

I'm not sure if we need support for dependencies and/or standalone .exe applications for this to work.

I would say this is a very special case since the external dependency (.NET Framework 3.5) is not a regular program/package but has to be enabled as a Windows feature.

@denelon
Copy link
Contributor

denelon commented May 5, 2021

@chausner we added support for Windows Features as a possible type of dependency in the v1.0 schema. We're still looking into the implications of making Windows Features as dependencies since it may require a reboot. I've seen one suggestion where they are created as "packages" so the package level dependency could be used. More analysis is required to understand edge cases and the best UX.

@denelon denelon removed their assignment Feb 11, 2022
@KevinLaMS KevinLaMS removed their assignment Feb 22, 2022
@KevinLaMS
Copy link
Contributor

Clearing assignees until unblocked.

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Mar 13, 2022
@Trenly Trenly mentioned this pull request Nov 28, 2022
1 task
@Trenly
Copy link
Contributor

Trenly commented Feb 10, 2023

I'm going to close this PR because it is so old and doesn't conform to any of the current schemas. Additionally, the base branch is (at the time of writing) 84,000 commits behind master and it would be better to create new manifests rather than rebasing or merging in master. I will leave #96043 open to track the progress against WiXToolset, as it is based on the latest updates to the manifest schema and is a newer branch from master. Thank you for your PR!

Close with reason: See above;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocking-Issue Manifest validation is blocked by a known issue. Dependencies Moderator-Approved One of the Moderators has reviewed and approved this PR Validation-Installation-Error Error installing application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants