Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETFoundation.WixToolset version 3.11.2 #25268

Closed
wants to merge 1 commit into from
Closed

NETFoundation.WixToolset version 3.11.2 #25268

wants to merge 1 commit into from

Conversation

alphaleonis
Copy link

@alphaleonis alphaleonis commented Aug 17, 2021

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost
Copy link

ghost commented Aug 17, 2021

CLA assistant check
All CLA requirements met.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alphaleonis
Copy link
Author

Note: The installer requires .NET Framework 3.5 enabled. Not sure if this can be indicated in the manifest somehow, or if this is a blocker?

@alphaleonis
Copy link
Author

I just noticed this was already submitted (twice) before in PR #895 (and #23647 stale). Closing this one.

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Aug 17, 2021
@ghost
Copy link

ghost commented Aug 17, 2021

Hello @alphaleonis,
During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect then the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

@ghost ghost assigned alphaleonis Aug 17, 2021
@ghost ghost added Needs: author feedback Needs-Author-Feedback This needs a response from the author. labels Aug 17, 2021
@Trenly Trenly mentioned this pull request Nov 28, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Author-Feedback This needs a response from the author. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants