Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to Electron 6.x #75802

Merged
merged 602 commits into from
Sep 13, 2019
Merged

chore: Update to Electron 6.x #75802

merged 602 commits into from
Sep 13, 2019

Conversation

deepak1556
Copy link
Collaborator

@deepak1556 deepak1556 commented Jun 20, 2019

Electron: 6.0.7
Nodejs version: 12.4.0
V8 version: 7.6.303.29
Chromium version: 76.0.3809.139

@bpasero bpasero added this to the On Deck milestone Jun 24, 2019
@bpasero bpasero mentioned this pull request Jun 25, 2019
yarn.lock Outdated Show resolved Hide resolved
}
dialogPromise.then(({ response, checkboxChecked }: Electron.MessageBoxReturnValue) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepak1556 easier if converted to async/await

@svipas
Copy link
Contributor

svipas commented Jul 8, 2019

Sorry for off topic, but I wanted to say thanks to @deepak1556 for this PR, I tried it and finally font weight is fixed with this Electron version. I'm very happy and looking forward to using Insiders with Electron 6.x. 🎆

@bpasero
Copy link
Member

bpasero commented Jul 12, 2019

@deepak1556 fyi see afcd155 for converting dialogs to async and a fix with normalizing paths.

@deepak1556
Copy link
Collaborator Author

deepak1556 commented Jul 26, 2019

The macOS crash is due to new helper binaries introduced with electron/electron#19324 , will need to update gulp-atom-electron for rewriting the names of these additional helpers.

Edit: joaomoreno/gulp-atom-electron#55

/cc @joaomoreno

@chpxu
Copy link

chpxu commented Jul 29, 2019

Electron 6.0.0-beta.15 is out

the previous one, .14 updated to Node 12.4.0

Noticed some webview issues fixed which could help?

  • Fixed not working in scriptable popups when nativeWindowOpen is enabled.
  • Fixed setting src on being too slow.
  • Preload scripts for internal <iframe> in are not longer executed when nodeIntegrationInSubFrames is enabled.

package.json Outdated Show resolved Hide resolved
deepak1556 and others added 25 commits September 12, 2019 08:22
@bpasero bpasero merged commit 029e992 into master Sep 13, 2019
@bpasero bpasero deleted the electron-6.0.x branch September 13, 2019 12:53
@WSLUser
Copy link

WSLUser commented Sep 20, 2019

Version update available: electron/electron@10a9e9c

@deepak1556 deepak1556 removed this from the September 2019 milestone Oct 3, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants